Merge lp:~ballot/codetree/fix_httphandler_write into lp:codetree

[Benjamin Allot]

Write the file as binary blob when read from HTTP response

[Benjamin Allot (ballot)]

This fixes the issue seen here: https://pastebin.canonical.com/p/YgF4Q7Jxvh/

[🤖 Canonical IS Merge Bot (canonical-is-mergebot)]

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

[Stuart Bishop (stub)]

+1

review: Approve

[🤖 Canonical IS Merge Bot (canonical-is-mergebot)]

Change successfully merged at revision 118

=== modified file 'codetree/handlers/basic.py'
--- codetree/handlers/basic.py	2020-04-08 09:27:18 +0000
+++ codetree/handlers/basic.py	2020-06-12 20:36:17 +0000
@@ -97,7 +97,7 @@
             logging.error("Failed to download {}: {}".format(self.source, e.reason))
             result.success = False
             return result
-        with open(dest, "w") as f:
+        with open(dest, "wb") as f:
             f.write(response.read())
         return result
 

=== modified file 'tests/test_basic_handlers.py'
--- tests/test_basic_handlers.py	2020-04-08 09:27:18 +0000
+++ tests/test_basic_handlers.py	2020-06-12 20:36:17 +0000
@@ -212,7 +212,7 @@
         with patch('codetree.handlers.basic.open', _open, create=True):
             self.assertTrue(hh.get(destfile, {}))
         self.assertFalse(_unlink.called)
-        _open.assert_called_with(destfile, "w")
+        _open.assert_called_with(destfile, "wb")
         _urlopen.assert_called_with(HttpURLs[0])
 
     @patch('codetree.handlers.basic.os.unlink')
@@ -248,7 +248,7 @@
         with patch('codetree.handlers.basic.open', _open, create=True):
             self.assertTrue(hh.get(destfile, options={"overwrite": True}))
         _unlink.assert_called_with(destfile)
-        _open.assert_called_with(destfile, "w")
+        _open.assert_called_with(destfile, "wb")
         _urlopen.assert_called_with(HttpURLs[0])
 
     @patch('codetree.handlers.basic.os.unlink')