Merge lp:~ballot/charms/xenial/daisy-retracer/lp1845257 into lp:~daisy-pluckers/charms/xenial/daisy-retracer/trunk

[Benjamin Allot]

[lp:~ballot/charms/xenial/daisy-retracer/lp1845257]

206. By Benjamin Allot on 2020-04-19

Add RestartSec directive and increase StartLimitBurst

The rationale behind this change is that the default RestartSec is 100ms.
Upon error of the service (because of a crash or whatever), it attempts to restart
very quickly 5 times, then stay in a failed state until manually restarted.

As seen in systemd.unit manual for the StartLimitBurst setting:

  Note that units which are configured for Restart= and which reach the start limit
  are not attempted to be restarted anymore;

The new limit try one restart every 10 seconds and the StartLimitInterval is set to
StartLimitBurst * RestartSec to avoid reaching this state.

[Junien F (axino)]

+1

review: Approve

[Brian Murray (brian-murray)]

In bug 1845257 Dimitri has asked for the unit log files so we can try to figure out why exactly the units are failing to restart. Could those please be provided to the bug report? Thanks in advance.

review: Needs Information

[Brian Murray (brian-murray)]

I'm rejecting this in favor of another change I made to the retracing service.

review: Disapprove

Unmerged revisions

206. By Benjamin Allot on 2020-04-19

Add RestartSec directive and increase StartLimitBurst

The rationale behind this change is that the default RestartSec is 100ms.
Upon error of the service (because of a crash or whatever), it attempts to restart
very quickly 5 times, then stay in a failed state until manually restarted.

As seen in systemd.unit manual for the StartLimitBurst setting:

  Note that units which are configured for Restart= and which reach the start limit
  are not attempted to be restarted anymore;

The new limit try one restart every 10 seconds and the StartLimitInterval is set to
StartLimitBurst * RestartSec to avoid reaching this state.

=== modified file 'hooks/common'
--- hooks/common	2019-06-12 16:13:09 +0000
+++ hooks/common	2020-04-19 15:31:17 +0000
@@ -189,12 +189,13 @@
 [Unit]
 Description="Error Tracker retracer for $arch"
 StartLimitInterval=60
-StartLimitBurst=5
+StartLimitBurst=6
 
 [Service]
 Environment="PYTHONPATH=$LOCAL_CONFIG_LOCATION:$CODE_LOCATION:$APPORT_LOCATION:$DEPLOY_ROOT" "PATH=$APPORT_LOCATION/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin"
 ExecStart=$CODE_LOCATION/daisy/retracer.py --config-dir $CODE_LOCATION/retracer/config $SANDBOX --output $LOG_DIR/retracer-$arch.log --architecture $arch --core-storage $VAR_DIR $CACHE_DEBS $CLEANUP_SANDBOX $CLEANUP_DEBS $FAILED_QUEUE $STACKTRACE_SOURCE $RETRACER_VERBOSE
 Restart=always
+RestartSec=10
 TimeoutStopSec=180
 
 [Install]