Merge ~ballot/cassandra-charm/+git/cassandra-charm:expose_internode into cassandra-charm:master

Proposed by Benjamin Allot
Status: Merged
Approved by: Colin Misare
Approved revision: 7e66ce6bfef70eadb4987621527faaa075d5830c
Merged at revision: 7566442faa9d8fc4717513ddd73006bb1f86b52c
Proposed branch: ~ballot/cassandra-charm/+git/cassandra-charm:expose_internode
Merge into: cassandra-charm:master
Diff against target: 135 lines (+10/-98)
1 file modified
Makefile (+10/-98)
Reviewer Review Type Date Requested Status
Colin Misare Approve
Canonical IS Reviewers Pending
Review via email: mp+445868@code.launchpad.net

Commit message

Add build and publish target for Makefile

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
Colin Misare (cmisare) wrote :

LGTM

review: Approve
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision 7566442faa9d8fc4717513ddd73006bb1f86b52c

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/Makefile b/Makefile
2index a118932..b1669d1 100644
3--- a/Makefile
4+++ b/Makefile
5@@ -16,15 +16,19 @@
6 # You should have received a copy of the GNU General Public License
7 # along with this program. If not, see <http://www.gnu.org/licenses/>.
8
9-BUILDDEST ?= ${JUJU_REPOSITORY}
10-BUILDDEST ?= ./build
11-
12 SHELL := /bin/bash
13 export SHELLOPTS:=errexit:pipefail
14
15+clean:
16+ charmcraft clean
17+
18+charmbuild: clean
19+ charmcraft pack
20+
21+publish:
22+ charmcraft upload cassandra_ubuntu-20.04-amd64_ubuntu-18.04-amd64_ubuntu-16.04-amd64.charm
23+ @echo "To release, run charmcraft release --channel <stable|edge|beta|candidate> --revision <revision> cassandra "
24
25-charmbuild:
26- charm build --no-local-layers -w wheelhouse_overrides.txt -o ${BUILDDEST}
27
28 testdeps:
29 sudo apt install tox
30@@ -35,77 +39,8 @@ test: unittest
31 unittest:
32 tox
33
34+.PHONY: clean charmbuild testdeps test unittest
35
36-# ftest: unittest Test1UnitDeployment
37-# Test1UnitDeployment: deps
38-# date
39-# AMULET_TIMEOUT=5400 \
40-# $(NOSETESTS) tests.test_integration:Test1UnitDeployment 2>&1 | ts
41-#
42-# 20test: unittest Test20Deployment
43-# Test20Deployment: deps
44-# date
45-# AMULET_TIMEOUT=5400 \
46-# $(NOSETESTS) tests.test_integration:Test20Deployment 2>&1 | ts
47-#
48-# 21test: unittest Test21Deployment
49-# Test21Deployment: deps
50-# date
51-# AMULET_TIMEOUT=5400 \
52-# $(NOSETESTS) tests.test_integration:Test21Deployment 2>&1 | ts
53-#
54-# 22test: unittest Test22Deployment
55-# Test22Deployment: deps
56-# date
57-# AMULET_TIMEOUT=5400 \
58-# $(NOSETESTS) tests.test_integration:Test22Deployment 2>&1 | ts
59-#
60-# 3test: unittest Test3UnitDeployment
61-# Test3UnitDeployment: deps
62-# date
63-# AMULET_TIMEOUT=7200 \
64-# $(NOSETESTS) tests.test_integration:Test3UnitDeployment 2>&1 | ts
65-#
66-# authtest: unittest TestAllowAllAuthenticatorDeployment
67-# TestAllowAllAuthenticatorDeployment: deps
68-# date
69-# AMULET_TIMEOUT=7200 \
70-# $(NOSETESTS) \
71-# tests.test_integration:TestAllowAllAuthenticatorDeployment 2>&1 | ts
72-#
73-# # Place a copy of the Oracle Java SE 8 Server Runtime tarball in ./lib
74-# # to run these tests.
75-# jretest: unittest
76-# AMULET_TIMEOUT=5400 \
77-# $(NOSETESTS) tests.test_integration:TestOracleJREDeployment 2>&1 | ts
78-#
79-# # You need the Oracle JRE (per jretest) and set the DSE_SOURCE environment
80-# # variable for this to work:
81-# # DSE_SOURCE="deb http://un:pw@debian.datastax.com/enterprise stable main"
82-# # You will also need a cache like squid-deb-proxy and have tweaked it to
83-# # cache the authenticated files, or the tests will likely timeout waiting
84-# # for huge downloads to complete. Alternatively, mirror the DataStax
85-# # packages into your own private archive.
86-# dsetest: unittest
87-# AMULET_TIMEOUT=5400 \
88-# $(NOSETESTS) tests.test_integration:TestDSEDeployment 2>&1 | ts
89-#
90-# coverage: lint
91-# $(NOSETESTS) \
92-# tests.test_actions --cover-package=actions \
93-# tests.test_helpers --cover-package=helpers \
94-# tests.test_definitions --cover-package=definitions \
95-# --with-coverage --cover-branches \
96-# --cover-html --cover-html-dir=coverage \
97-# --cover-min-percentage=100 || \
98-# (gnome-open coverage/index.html; false)
99-#
100-# clean:
101-# rm -rf .venv? tests/.venv? .stamp-* coverage .coverage
102-# find . -name __pycache__ -type d | xargs rm -rf
103-# find . -name \*~ -type f | xargs rm -f
104-#
105-#
106 #
107 # venv3: .stamp-venv3
108 # .stamp-venv3:
109@@ -148,26 +83,3 @@ unittest:
110 # echo '!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!'; \
111 # echo '!!! There are uncommitted changes !!!'; \
112 # echo '!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!'; \
113-# false; \
114-# fi
115-# git clean -fdx
116-# export rev=`charm push . $(CHARM_STORE_URL) 2>&1 \
117-# | tee /dev/tty | grep url: | cut -f 2 -d ' '` \
118-# && git tag -f -m "$$rev" `echo $$rev | tr -s '~:/' -` \
119-# && git push --tags $(REPO) \
120-# && charm release -c development $$rev
121-#
122-#
123-# publish-stable:
124-# @if [ -n "`git status --porcelain`" ]; then \
125-# echo '!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!'; \
126-# echo '!!! There are uncommitted changes !!!'; \
127-# echo '!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!'; \
128-# false; \
129-# fi
130-# git clean -fdx
131-# export rev=`charm push . $(CHARM_STORE_URL) 2>&1 \
132-# | tee /dev/tty | grep url: | cut -f 2 -d ' '` \
133-# && git tag -f -m "$$rev" `echo $$rev | tr -s '~:/' -` \
134-# && git push --force --tags $(REPO) \
135-# && charm release -c stable $$rev

Subscribers

People subscribed via source and target branches