Merge lp:~ballogy/ubuntu-sso-client/drop-lazr into lp:ubuntu-sso-client

[Balló György]

Removed the lazr.restfulclient dependency by removing TimestampedAuthorizer class.

This change removes lazr.restfulclient dependency by removing TimestampedAuthorizer class. It seems that TimestampedAuthorizer is not used by ubuntu-sso-client or ubuntuone-client, so I request to remove it.

I'm packaging Ubuntu One client for Arch Linux and this change makes it much easier, because I don't need to package lazr.restfulclient, lazr.uri and python-wadllib.

[Manuel de la Peña (mandel)]

Make sense, I've added alecu and I to take a look at this to make sure it is ok, but from a quick look I see no problems..

[Alejandro J. Cura (alecu)]

Looks good!
We should have done this earlier, but somehow it dropped from our radar.
Thanks a lot for finding it!

review: Approve

[Manuel de la Peña (mandel)]

I'm approving this too and I've added bug #1005544 and bug 1005548 to ensure we clean the code in all left places.

review: Approve

[Ubuntu One Auto Pilot (otto-pilot)]

The attempt to merge lp:~ballogy/ubuntu-sso-client/drop-lazr into lp:ubuntu-sso-client failed. Below is the output from the failed tests.

*** Running GTK test suite for ubuntu_sso ***
Starting squid version...
Waiting for squid to start....
Waiting for squid to start.....
ubuntu_sso.main.tests.test_common
  BaseTestCase
    runTest ... [OK]
  CredentialsManagementClearTestCase
    test_backend_called ... [OK]
    test_does_not_block ... [OK]
    test_handles_error ... [OK]
  CredentialsManagementFindTestCase
    test_backend_called ... [OK]
    test_does_not_block ... [OK]
    test_find_credentials_with_error_cb ... [OK]
    test_find_credentials_with_success_cb ... [OK]
    test_handles_error ... [OK]
  CredentialsManagementNotFindTestCase
    test_backend_called ... [OK]
    test_does_not_block ... [OK]
    test_find_credentials_with_error_cb ... [OK]
    test_find_credentials_with_success_cb ... [OK]
    test_handles_error ... [OK]
  CredentialsManagementOpsTestCase
    test_login ... [OK]
    test_login_email_password ... [OK]
    test_register ... [OK]
  CredentialsManagementParamsTestCase
    test_login ... [OK]
    test_login_email_password ... [OK]
    test_register ... [OK]
  CredentialsManagementRefCountingTestCase
    test_authorization_denied ... [OK]
    test_autorization_denied_when_ref_count_is_not_positive ... [OK]
    test_clear_credentials ... [OK]
    test_credentials_cleared ... [OK]
    test_credentials_cleared_when_ref_count_is_not_positive ... [OK]
    test_credentials_error ... [OK]
    test_credentials_error_when_ref_count_is_not_positive ... [OK]
    test_credentials_found ... [OK]
    test_credentials_found_when_ref_count_is_not_positive ... [OK]
    test_credentials_not_found ... [OK]
    test_credentials_not_found_when_ref_count_is_not_positive ... [OK]
    test_credentials_stored ... [OK]
    test_credentials_stored_when_ref_count_is_not_positive ... [OK]
    test_...

=== modified file 'ubuntu_sso/account.py'
--- ubuntu_sso/account.py	2012-04-09 17:38:24 +0000
+++ ubuntu_sso/account.py	2012-05-24 03:08:19 +0000
@@ -38,7 +38,6 @@
 import os
 import re
 
-from lazr.restfulclient.authorize.oauth import OAuthAuthorizer
 from oauth import oauth
 from twisted.internet import defer
 
@@ -54,27 +53,6 @@
 SSO_STATUS_ERROR = 'error'
 
 
-class TimestampedAuthorizer(OAuthAuthorizer):
-    """Includes a custom timestamp on OAuth signatures."""
-
-    def __init__(self, get_timestamp, *args, **kwargs):
-        """Store the get_timestamp method, and move on."""
-        super(TimestampedAuthorizer, self).__init__(*args, **kwargs)
-        self.get_timestamp = get_timestamp
-
-    # pylint: disable=C0103
-    def authorizeRequest(self, absolute_uri, method, body, headers):
-        """Override authorizeRequest including the timestamp."""
-        parameters = {"oauth_timestamp": self.get_timestamp()}
-        oauth_request = oauth.OAuthRequest.from_consumer_and_token(
-            self.consumer, self.access_token, http_url=absolute_uri,
-            parameters=parameters)
-        oauth_request.sign_request(
-            oauth.OAuthSignatureMethod_PLAINTEXT(),
-            self.consumer, self.access_token)
-        headers.update(oauth_request.to_header(self.oauth_realm))
-
-
 class InvalidEmailError(Exception):
     """The email is not valid."""
 

=== modified file 'ubuntu_sso/tests/test_account.py'
--- ubuntu_sso/tests/test_account.py	2012-04-09 17:38:24 +0000
+++ ubuntu_sso/tests/test_account.py	2012-05-24 03:08:19 +0000
@@ -51,7 +51,6 @@
     ResetPasswordTokenError,
     SSO_STATUS_OK,
     SSO_STATUS_ERROR,
-    TimestampedAuthorizer,
 )
 from ubuntu_sso.tests import (
     APP_NAME,
@@ -203,36 +202,6 @@
             return defer.fail(e)
 
 
-class TimestampedAuthorizerTestCase(TestCase):
-    """Test suite for the TimestampedAuthorizer."""
-
-    def test_authorize_request_includes_timestamp(self):
-        """The authorizeRequest method includes the timestamp."""
-        fromcandt_call = []
-        fake_uri = "http://protocultura.net"
-        fake_timestamp = 1234
-        get_fake_timestamp = lambda: fake_timestamp
-        original_oauthrequest = oauth.OAuthRequest
-
-        class FakeOAuthRequest(oauth.OAuthRequest):
-            """A Fake OAuthRequest class."""
-
-            @staticmethod
-            def from_consumer_and_token(*args, **kwargs):
-                """A fake from_consumer_and_token."""
-                fromcandt_call.append((args, kwargs))
-                builder = original_oauthrequest.from_consumer_and_token
-                return builder(*args, **kwargs)
-
-        self.patch(oauth, "OAuthRequest", FakeOAuthRequest)
-
-        authorizer = TimestampedAuthorizer(get_fake_timestamp, "ubuntuone")
-        authorizer.authorizeRequest(fake_uri, "POST", None, {})
-        call_kwargs = fromcandt_call[0][1]
-        parameters = call_kwargs["parameters"]
-        self.assertEqual(parameters["oauth_timestamp"], fake_timestamp)
-
-
 class AccountTestCase(TestCase):
     """Test suite for the SSO login processor."""