Code review comment for lp:~ballogy/indicator-session/better-fallback-icon

Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

This would break bug https://bugs.launchpad.net/indicator-appmenu/+bug/1088778 again; in the way that all g_themed_icon_new_with_default_fallbacks() does is shorten the name at dashes until it finds a match; but doesn't take into account the cases where there are none -- which should still be gtk_missing_icon.

review: Needs Fixing

« Back to merge proposal