Merge lp:~ballogy/indicator-session/better-fallback-icon into lp:indicator-session/13.04
Status: | Work in progress | ||||
---|---|---|---|---|---|
Proposed branch: | lp:~ballogy/indicator-session/better-fallback-icon | ||||
Merge into: | lp:indicator-session/13.04 | ||||
Diff against target: |
65 lines (+5/-22) 1 file modified
src/indicator-session.c (+5/-22) |
||||
To merge this branch: | bzr merge lp:~ballogy/indicator-session/better-fallback-icon | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Lars Karlitski (community) | Needs Information | ||
Mathieu Trudel-Lapierre | Needs Fixing | ||
Review via email: mp+141608@code.launchpad.net |
Description of the change
This change reverts the commit 358 [1], and provides a better and simpler fallback icon handling.
Instead of monitoring theme changes and use a hard-coded "gtk-missing-image" as fallback, use g_themed_
[1] http://
Unmerged revisions
- 381. By Balló György
-
Improve fallback icon handling
Instead of monitoring theme changes and use a
hard-coded "gtk-missing-image", use
g_themed_icon_new_ with_default_ fallbacks () to get a proper fallback
icon (e.g. "system").
This would break bug https:/ /bugs.launchpad .net/indicator- appmenu/ +bug/1088778 again; in the way that all g_themed_ icon_new_ with_default_ fallbacks( ) does is shorten the name at dashes until it finds a match; but doesn't take into account the cases where there are none -- which should still be gtk_missing_icon.