Merge lp:~ballogy/gnome-control-center-signon/no-hardcode-ubuntu into lp:gnome-control-center-signon

Proposed by Balló György on 2012-12-03
Status: Needs review
Proposed branch: lp:~ballogy/gnome-control-center-signon/no-hardcode-ubuntu
Merge into: lp:gnome-control-center-signon
Diff against target: 74 lines (+8/-8)
3 files modified
help/C/legal-notice.page (+4/-4)
libaccount-plugin/oauth-plugin.c (+1/-1)
src/cc-credentials-account-details-page.vala (+3/-3)
To merge this branch: bzr merge lp:~ballogy/gnome-control-center-signon/no-hardcode-ubuntu
Reviewer Review Type Date Requested Status
Alberto Mardegan (community) 2012-12-03 Needs Fixing on 2013-03-19
PS Jenkins bot (community) continuous-integration Needs Fixing on 2012-12-03
David King (community) Needs Information on 2012-12-03
Review via email: mp+137462@code.launchpad.net

Description of the change

Generalize the term of Ubuntu

Use the term "computer" instead of "Ubuntu", because the latter confuses users of other GNU/Linux distributions.

Related bug report:
https://bugs.launchpad.net/gnome-control-center-signon/+bug/1076047

To post a comment you must log in.
Alberto Mardegan (mardy) wrote :

Thanks György! :-) Looks good to me.

review: Approve
David King (amigadave) wrote :

As this changes the legal notice, we should at least get a signoff from legal before approving it.

review: Needs Information
Víctor R. Ruiz (vrruiz) wrote :

I modified Jenkins configuration to build in raring.

Balló György (ballogy) wrote :

Is there any progress?

Alberto Mardegan (mardy) wrote :

Hi György. Please see the related bug report for the design team's reply.

In short, we don't want to change that in Ubuntu. If you could come up with another patch which makes "Ubuntu" a variable which can be overridden at build time, we would certainly welcome that.

For the legal notice file, you could probably create a "legal-notice.page.in" file and substitute the "Ubuntu"/"your computer" text via autoconf.

(this is just a suggestion: other solutions which preserve the Ubuntu name when the package is built in Ubuntu are acceptable)

Alberto Mardegan (mardy) :
review: Needs Fixing
Balló György (ballogy) wrote :

Thanks for the response. Unfortunately, I don't have the knowledge how to fix the patch in this way.

It would be nice if upstream developers would solve this problem.

Unmerged revisions

125. By Balló György on 2012-12-03

Generalize the term of Ubuntu

Use the term "computer" instead of "Ubuntu", because the latter confuse users of other GNU/Linux distributions.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'help/C/legal-notice.page'
2--- help/C/legal-notice.page 2012-09-25 13:14:37 +0000
3+++ help/C/legal-notice.page 2012-12-03 02:15:28 +0000
4@@ -36,18 +36,18 @@
5
6 <p>You provide Ubuntu Online Accounts with your name and password(s)
7 (credentials) for those online services you want Ubuntu Online Accounts to
8- authenticate while using Ubuntu.</p>
9+ authenticate while using your computer.</p>
10
11 <p>Ubuntu Online Accounts collects and stores your credentials when you
12 enter them in the web authentication dialog and uses them, and
13 authentication cookies, to provide authentication to those online services
14- each time you access them while using Ubuntu.</p>
15+ each time you access them while using your computer.</p>
16
17 <p>By using Ubuntu Online Accounts you consent to:</p>
18 <list>
19 <item><p>the collection and use of your credentials in this way;</p></item>
20 <item><p>the use of authentication cookies; and</p></item>
21- <item><p>the storage of your credentials and the authentication cookies on your Ubuntu computer.</p></item>
22+ <item><p>the storage of your credentials and the authentication cookies on your computer.</p></item>
23 </list>
24 <p>Canonical will not access or use your credentials or authentication
25 cookies in any other way.</p>
26@@ -70,7 +70,7 @@
27 <p>You may cease using Ubuntu Online Accounts at any time. If you cease
28 using Ubuntu Online Accounts, or wish to cease using it for certain online
29 services, please ensure that you have removed all of your credentials from
30- the “Online Accounts” entry of your Ubuntu System Settings.</p>
31+ the “Online Accounts” entry of your system settings.</p>
32 </section>
33
34 <section id="changes">
35
36=== modified file 'libaccount-plugin/oauth-plugin.c'
37--- libaccount-plugin/oauth-plugin.c 2012-11-05 13:27:05 +0000
38+++ libaccount-plugin/oauth-plugin.c 2012-12-03 02:15:28 +0000
39@@ -581,7 +581,7 @@
40 G_CALLBACK (on_infobar_response), self);
41
42 provider = ap_plugin_get_provider ((ApPlugin *)self);
43- text = g_strdup_printf (_("Please authorize Ubuntu to access "
44+ text = g_strdup_printf (_("Please authorize this computer to access "
45 "your %s account"),
46 ag_provider_get_display_name (provider));
47 infobar_label = gtk_label_new (text);
48
49=== modified file 'src/cc-credentials-account-details-page.vala'
50--- src/cc-credentials-account-details-page.vala 2012-10-25 14:42:58 +0000
51+++ src/cc-credentials-account-details-page.vala 2012-12-03 02:15:28 +0000
52@@ -459,7 +459,7 @@
53
54 if (needs_attention)
55 {
56- frame_label.label = _("Please authorize Ubuntu to access your %s account:").printf
57+ frame_label.label = _("Please authorize this computer to access your %s account:").printf
58 (provider_display_name);
59
60 action_notebook.page = ActionPage.ACCESS_BUTTON;
61@@ -490,11 +490,11 @@
62 Gtk.MessageType.QUESTION,
63 Gtk.ButtonsType.NONE,
64 "%s",
65- _("Are you sure that you wish to remove this Ubuntu Web Account?"));
66+ _("Are you sure that you wish to remove this web account?"));
67 var manager = accounts_store.manager;
68 var provider = manager.get_provider (current_account.get_provider_name ());
69 var provider_display_name = provider.get_display_name ();
70- var secondary_text = _("The Web Account which manages the integration of %s with your applications will be removed.").printf (provider_display_name)
71+ var secondary_text = _("The web account which manages the integration of %s with your applications will be removed.").printf (provider_display_name)
72 + "\n\n"
73 + _("Your online %s account is not affected.").printf (provider_display_name);
74 confirmation.secondary_text = secondary_text;

Subscribers

People subscribed via source and target branches