Code review comment for lp:~ballogy/bamf-qt/fix-imports-dir-location

Revision history for this message
Olivier Tilloy (osomon) wrote :

Thanks György.
There’s a couple more issues with that change though:

 - IMPORT_INSTALL_DIR should be a relative path, just like INCLUDE_INSTALL_DIR, i.e. the /usr/ prefix should somehow be truncated in a clever way. This is needed so that installing to a different prefix works.

 - debian/libqtbamf1.install should be updated too (it should be generated), so that the path to the QML plugin is not hardcoded.

I understand that your interests lie in making a package for ArchLinux, so I can take care of the second point later on, but the first point needs to be addressed. Thanks!

review: Needs Fixing

« Back to merge proposal