Merge ~baconyao/checkbox-limerick/+git/checkbox-provider-limerick:master into ~checkbox-dev/checkbox-limerick/+git/checkbox-provider-limerick:master

Proposed by PeiYao Chang
Status: Merged
Approved by: PeiYao Chang
Approved revision: 998d3084e0dc7a9f14d6d4d5526e80684e11bc06
Merged at revision: 0ffc0e155d9e59c890da556bd89498f055659eb2
Proposed branch: ~baconyao/checkbox-limerick/+git/checkbox-provider-limerick:master
Merge into: ~checkbox-dev/checkbox-limerick/+git/checkbox-provider-limerick:master
Diff against target: 105 lines (+65/-0)
4 files modified
units/kd240-test-plan-classic.pxu (+3/-0)
units/thermal-sensor/category.pxu (+3/-0)
units/thermal-sensor/jobs.pxu (+23/-0)
units/thermal-sensor/test-plan.pxu (+36/-0)
Reviewer Review Type Date Requested Status
Vincent Liao Approve
Patrick Liu (community) Approve
Vic Liu Approve
Rick Wu Pending
StanleyHuang Pending
Review via email: mp+445488@code.launchpad.net

Commit message

    Add: KD240 thermal test case

    According to the comment#5 in LP#2021464, Xilinx customer points out the
    internal temperature can be read from temp1_input of hwmon0, therefore,
    I add this customized job to test thermal.

Description of the change

The sideload result: https://certification.canonical.com/hardware/202304-31517/submission/320972/test-results/?term=hwmon0

However, it seems that the way we are using to test thermal by stress-ng is not a suitable way.
1. The temperature after doing stress-ng may not be higher than before.
2. I have tried to heat the core by hair dryer, and the temperature grows up obviously, this means the thermal can reflect the temperature of environment.
3. I am not sure is there a magic mechanism to cool down the core by design, so I will file an issue about this phenomenon.

Conclusion, even though this job may not be the right testing, I still hope it can be included first, then modified it based on the further discussion.

Lets track issue in LP:2025211

To post a comment you must log in.
Revision history for this message
Vic Liu (zongminl) wrote :

+1, thank you

review: Approve
Revision history for this message
Patrick Liu (patliu) wrote :

LGTM

review: Approve
Revision history for this message
Vincent Liao (liaou3) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/units/kd240-test-plan-classic.pxu b/units/kd240-test-plan-classic.pxu
2index 1b1f258..ef47a47 100644
3--- a/units/kd240-test-plan-classic.pxu
4+++ b/units/kd240-test-plan-classic.pxu
5@@ -44,9 +44,11 @@ bootstrap_include:
6 limerick_sku
7 nested_part:
8 dtb-automated
9+ limerick-thermal-sensor-automated
10 com.canonical.certification::rtc-automated
11 com.canonical.qa.ceoem::ce-oem-automated
12 com.canonical.certification::client-cert-iot-server-22-04-automated
13+ after-suspend-limerick-thermal-sensor-automated
14 com.canonical.certification::after-suspend-networking-automated
15 com.canonical.qa.ceoem::after-suspend-ce-oem-automated
16 com.canonical.certification::after-suspend-rtc-automated
17@@ -56,6 +58,7 @@ exclude:
18 com.canonical.certification::power-management/cold-reboot # LP:2017486
19 com.canonical.certification::power-management/post-cold-reboot # LP:2017486
20 com.canonical.qa.ceoem::ce-oem-eeprom/read-write # LP:2021487
21+ com.canonical.qa.ceoem::after-suspend-ce-oem-eeprom/read-write # LP:2021487
22 com.canonical.qa.ceoem::ce-oem-cpu/offlining_test # LP:2021990
23 com.canonical.qa.ceoem::ce-oem-sensor/thermal # LP:2021464
24 com.canonical.qa.ceoem::after-suspend-ce-oem-sensor/thermal # LP:2021464
25diff --git a/units/thermal-sensor/category.pxu b/units/thermal-sensor/category.pxu
26new file mode 100644
27index 0000000..a2f72b9
28--- /dev/null
29+++ b/units/thermal-sensor/category.pxu
30@@ -0,0 +1,3 @@
31+unit: category
32+id: limerick-thermal-sensor
33+_name: Limerick Thermal Sensor
34\ No newline at end of file
35diff --git a/units/thermal-sensor/jobs.pxu b/units/thermal-sensor/jobs.pxu
36new file mode 100644
37index 0000000..2521ab4
38--- /dev/null
39+++ b/units/thermal-sensor/jobs.pxu
40@@ -0,0 +1,23 @@
41+id: limerick-thermal-sensor/hwmon0
42+_summary: Check thermal sensor - hwmon0 is activate
43+plugin: shell
44+user: root
45+command:
46+ echo "Sleep 10 seconds than start stress-ng for 50 seconds"
47+ sleep 10
48+ FILE=/sys/class/hwmon/hwmon0/temp1_input
49+ if [ -f "$FILE" ]
50+ then
51+ cur=$(cat "$FILE")
52+ printf "Before stress: %0.3f°C\n" "$(bc -l <<< "$cur/1000")"
53+ stress-ng --cpu 8 --io 4 --vm 2 --vm-bytes 128M --fork 4 --timeout 50s
54+ new=$(cat "$FILE")
55+ printf "After stress: %0.3f°C\n" "$(bc -l <<< "$new/1000")"
56+ [[ $new -gt $cur ]]
57+ else
58+ echo "ERROR: Cannot find the thermal sensor node in $FILE"
59+ exit 1
60+ fi
61+category_id: limerick-thermal-sensor
62+estimated_duration: 30
63+flags: preserve-locale also-after-suspend
64diff --git a/units/thermal-sensor/test-plan.pxu b/units/thermal-sensor/test-plan.pxu
65new file mode 100644
66index 0000000..f6f6be7
67--- /dev/null
68+++ b/units/thermal-sensor/test-plan.pxu
69@@ -0,0 +1,36 @@
70+id: limerick-thermal-sensor-full
71+unit: test plan
72+_name: Thermal sensor tests
73+_description: Full thermal sensor tests for devices
74+include:
75+nested_part:
76+ limerick-thermal-sensor-manual
77+ limerick-thermal-sensor-automated
78+ after-suspend-limerick-thermal-sensor-manual
79+ after-suspend-limerick-thermal-sensor-automated
80+
81+id: limerick-thermal-sensor-manual
82+unit: test plan
83+_name: Thermal sensor manual tests
84+_description: Manual thermal sensor tests for devices
85+include:
86+
87+id: limerick-thermal-sensor-automated
88+unit: test plan
89+_name: Thermal sensor auto tests
90+_description: Automated thermal sensor tests for devices
91+include:
92+ limerick-thermal-sensor/hwmon0
93+
94+id: after-suspend-limerick-thermal-sensor-manual
95+unit: test plan
96+_name: After suspend thermal sensor manual tests
97+_description: Manual after suspend thermal sensor tests for devices
98+include:
99+
100+id: after-suspend-limerick-thermal-sensor-automated
101+unit: test plan
102+_name: After suspend thermal sensor auto tests
103+_description: Automated after suspend thermal sensor tests for devices
104+include:
105+ after-suspend-limerick-thermal-sensor/hwmon0

Subscribers

People subscribed via source and target branches