Merge ~baconyao/checkbox-limerick/+git/checkbox-limerick-classic:adjust-kd240-launcher into ~checkbox-dev/checkbox-limerick/+git/checkbox-limerick-classic:master

Proposed by PeiYao Chang
Status: Merged
Approved by: PeiYao Chang
Approved revision: ab02f3a56b8b394e94cd1010a61eda5a5e2a056f
Merged at revision: 27cc1fb596016228dcedffe7e06cfb9c63796ec9
Proposed branch: ~baconyao/checkbox-limerick/+git/checkbox-limerick-classic:adjust-kd240-launcher
Merge into: ~checkbox-dev/checkbox-limerick/+git/checkbox-limerick-classic:master
Diff against target: 88 lines (+28/-4)
3 files modified
launchers/test-runner-kd240 (+12/-1)
launchers/wrapper_local (+4/-1)
snap/snapcraft.yaml (+12/-2)
Reviewer Review Type Date Requested Status
Vic Liu Approve
Review via email: mp+443446@code.launchpad.net

Commit message

Change: Integrate ce-oem provider and fix launcher

1. Update the snapcraft.yaml for building snap by snapcraft v7.x
2. Update the wrapper_local for integrating checkbox-provider-ce-oem
3. Update test-runner-kd240 launcher
  - Mark has_hardware_watchdog to be false due to LP#2017477
  - Add some manifests for checkbox-provider-ce-oem
  - Add environment variables for MTD and RTC jobs

Description of the change

The automated test result: https://certification.canonical.com/hardware/202304-31517/submission/314037/test-results/

It shows the checkbox-provider-ce-oem be integrated successfully.

To post a comment you must log in.
Revision history for this message
Vic Liu (zongminl) wrote :

Let's have the following machine manifest set to true as default:
com.canonical.certification::has_hardware_watchdog
com.canonical.qa.ceoem::has_eeprom

review: Needs Fixing
Revision history for this message
PeiYao Chang (baconyao) wrote :

> Let's have the following machine manifest set to true as default:
> com.canonical.certification::has_hardware_watchdog
> com.canonical.qa.ceoem::has_eeprom

Fixed, please review it again, thanks.

Revision history for this message
Vic Liu (zongminl) wrote :

+1, thank you

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/launchers/test-runner-kd240 b/launchers/test-runner-kd240
2index c1b6fde..ead35d7 100755
3--- a/launchers/test-runner-kd240
4+++ b/launchers/test-runner-kd240
5@@ -15,8 +15,8 @@ filter = com.canonical.qa.limerick::kd240-limerick-classic-22-04
6 com.canonical.certification::has_ethernet_adapter = true
7 com.canonical.certification::has_usb_storage = true
8 com.canonical.certification::has_i2c = true
9-com.canonical.certification::has_hardware_watchdog = true
10 com.canonical.certification::has_tpm2_chip = true
11+com.canonical.certification::has_hardware_watchdog = true
12 com.canonical.certification::has_audio_capture = false
13 com.canonical.certification::has_audio_loopback_connector = false
14 com.canonical.certification::has_audio_playback = false
15@@ -33,3 +33,14 @@ com.canonical.certification::has_dp = false
16 com.canonical.certification::has_vga = false
17 com.canonical.certification::has_dvi = false
18 com.canonical.certification::has_hdmi = false
19+com.canonical.qa.ceoem::has_buzzer = false
20+com.canonical.qa.ceoem::has_eeprom = true
21+com.canonical.qa.ceoem::has_gps = false
22+com.canonical.qa.ceoem::has_mtd = true
23+com.canonical.qa.ceoem::has_otg = false
24+com.canonical.qa.ceoem::has_rs485 = true
25+com.canonical.qa.ceoem::has_rs485_server = true
26+
27+[environment]
28+TOTAL_MTD_NUM=17
29+TOTAL_RTC_NUM=1
30diff --git a/launchers/wrapper_local b/launchers/wrapper_local
31index 2a65523..44a8f81 100755
32--- a/launchers/wrapper_local
33+++ b/launchers/wrapper_local
34@@ -31,12 +31,15 @@ export LC_ALL=C.UTF-8
35 PERL_VERSION=$(perl -e '$^V=~/^v(\d+\.\d+)/;print $1')
36 export PERL5LIB="$PERL5LIB:$SNAP/usr/lib/$ARCH/perl/$PERL_VERSION:$SNAP/usr/lib/$ARCH/perl5/$PERL_VERSION:$SNAP/usr/share/perl/$PERL_VERSION:$SNAP/usr/share/perl5"
37 export GI_TYPELIB_PATH=$SNAP/usr/lib/girepository-1.0:$SNAP/usr/lib/$ARCH/girepository-1.0
38-export PATH="$SNAP/usr/sbin:$SNAP/sbin:$SNAP/usr/bin:$SNAP/bin:/snap/bin:$PATH"
39+export PATH="$SNAP/usr/sbin:$SNAP/sbin:$SNAP/usr/bin:$SNAP/bin:/snap/bin:$PATH:/snap/checkbox-ce-oem/current/usr/bin/:/snap/checkbox-ce-oem/current/usr/sbin"
40 export ALSA_CONFIG_PATH=$SNAP/usr/share/alsa/alsa.conf:$SNAP/usr/share/alsa/pcm/default.conf
41 export PYTHONPATH="$SNAP/usr/lib/python3/dist-packages:$PYTHONPATH"
42+export LD_LIBRARY_PATH="$LD_LIBRARY_PATH:$SNAP/usr/bin:$SNAP/usr/lib:$SNAP/usr/lib/$ARCH:/snap/checkbox-ce-oem/current/usr/lib/aarch64-linux-gnu"
43
44 if [ -e $RUNTIME/wrapper_common_classic ]; then
45 . $RUNTIME/wrapper_common_classic
46+ # Append ce-oem provider
47+ export PROVIDERPATH="$PROVIDERPATH:/snap/checkbox-ce-oem/current/providers/checkbox-provider-ce-oem"
48 else
49 echo "ERROR: no $RUNTIME/wrapper_common_classic found"
50 exit 0
51diff --git a/snap/snapcraft.yaml b/snap/snapcraft.yaml
52index 9acabcb..308405e 100644
53--- a/snap/snapcraft.yaml
54+++ b/snap/snapcraft.yaml
55@@ -2,7 +2,7 @@ name: checkbox-limerick-classic
56 summary: Checkbox tests for the limerick classic project
57 description: |
58 Collection of tests to be run on devices that are part of the limerick project
59-version: '0.2dev-jammy'
60+version: '0.3dev-jammy'
61 confinement: classic
62 grade: stable
63
64@@ -46,13 +46,23 @@ passthrough:
65
66 parts:
67 checkbox-provider-limerick:
68- plugin: checkbox-provider
69+ plugin: dump
70 source: https://git.launchpad.net/~checkbox-dev/checkbox-limerick/+git/checkbox-provider-limerick
71 source-type: git
72 stage-packages:
73 - netperf
74 - iozone3
75 build-attributes: [no-patchelf]
76+ build-snaps:
77+ - checkbox22
78+ override-build: |
79+ export PYTHONPATH=/snap/checkbox22/current/lib/python3.10/site-packages/
80+ for path in $(find "/snap/checkbox22/current/providers/" -mindepth 1 -maxdepth 1 -type d); do export PROVIDERPATH=$path${PROVIDERPATH:+:$PROVIDERPATH}; done
81+ python3 manage.py validate
82+ python3 manage.py build
83+ python3 manage.py install --layout=relocatable --prefix=/providers/checkbox-provider-limerick --root="$SNAPCRAFT_PART_INSTALL"
84+ build-packages:
85+ - python3-jinja2
86 parts-meta-info:
87 plugin: nil
88 build-attributes: [no-patchelf]

Subscribers

People subscribed via source and target branches