Merge ~baconyao/checkbox-limerick/+git/checkbox-limerick-classic:add-kd240-launcher into ~checkbox-dev/checkbox-limerick/+git/checkbox-limerick-classic:master

Proposed by PeiYao Chang
Status: Merged
Approved by: PeiYao Chang
Approved revision: 4dac0103e5c65d991918506b35b118470617dbd2
Merged at revision: 34daa48a861d52af01d86faa620c8d1266a2c98f
Proposed branch: ~baconyao/checkbox-limerick/+git/checkbox-limerick-classic:add-kd240-launcher
Merge into: ~checkbox-dev/checkbox-limerick/+git/checkbox-limerick-classic:master
Diff against target: 55 lines (+38/-0)
2 files modified
launchers/test-runner-kd240 (+35/-0)
snap/snapcraft.yaml (+3/-0)
Reviewer Review Type Date Requested Status
Vic Liu Approve
Review via email: mp+441419@code.launchpad.net

Commit message

Add: Launcher for KD240 platform

To post a comment you must log in.
Revision history for this message
Vic Liu (zongminl) wrote :

Need fixing, please see my inline comments

review: Needs Fixing
Revision history for this message
PeiYao Chang (baconyao) wrote :

> Need fixing, please see my inline comments

Hi @Vic, I updated the name of test plan and enable the manifest of watchdog and tpm2.

Please review it again, thanks.

I will squash commits once you approve.

Revision history for this message
Vic Liu (zongminl) wrote :

LGTM, thank you.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/launchers/test-runner-kd240 b/launchers/test-runner-kd240
2new file mode 100755
3index 0000000..c1b6fde
4--- /dev/null
5+++ b/launchers/test-runner-kd240
6@@ -0,0 +1,35 @@
7+#!/usr/bin/env checkbox-cli-wrapper
8+[launcher]
9+app_id = com.canonical.qa.limerick:checkbox
10+launcher_version = 1
11+stock_reports = text, submission_files, certification
12+
13+[test plan]
14+unit = com.canonical.qa.limerick::kd240-limerick-classic-22-04
15+filter = com.canonical.qa.limerick::kd240-limerick-classic-22-04
16+ com.canonical.qa.limerick::kd240-limerick-classic-manual-22-04
17+ com.canonical.qa.limerick::kd240-limerick-classic-automated-22-04
18+ com.canonical.qa.limerick::kd240-limerick-classic-stress-22-04
19+
20+[manifest]
21+com.canonical.certification::has_ethernet_adapter = true
22+com.canonical.certification::has_usb_storage = true
23+com.canonical.certification::has_i2c = true
24+com.canonical.certification::has_hardware_watchdog = true
25+com.canonical.certification::has_tpm2_chip = true
26+com.canonical.certification::has_audio_capture = false
27+com.canonical.certification::has_audio_loopback_connector = false
28+com.canonical.certification::has_audio_playback = false
29+com.canonical.certification::has_bt_adapter = false
30+com.canonical.certification::has_bt_smart = false
31+com.canonical.certification::has_camera = false
32+com.canonical.certification::has_card_reader = false
33+com.canonical.certification::has_thunderbolt3 = false
34+com.canonical.certification::has_usb_type_c = false
35+com.canonical.certification::has_usbc_data = false
36+com.canonical.certification::has_wwan_module = false
37+com.canonical.certification::has_wlan_adapter = false
38+com.canonical.certification::has_dp = false
39+com.canonical.certification::has_vga = false
40+com.canonical.certification::has_dvi = false
41+com.canonical.certification::has_hdmi = false
42diff --git a/snap/snapcraft.yaml b/snap/snapcraft.yaml
43index ba04f59..9acabcb 100644
44--- a/snap/snapcraft.yaml
45+++ b/snap/snapcraft.yaml
46@@ -35,6 +35,9 @@ apps:
47 test-runner-vck190:
48 command-chain: [bin/wrapper_local]
49 command: bin/test-runner-vck190
50+ test-runner-kd240:
51+ command-chain: [bin/wrapper_local]
52+ command: bin/test-runner-kd240
53
54 passthrough:
55 hooks:

Subscribers

People subscribed via source and target branches