Merge lp:~bac/lpsetup/xbit into lp:lpsetup

[Brad Crittenden]

Invoke launchpad-database-setup using /bin/sh to avoid problem with the installer dropping the execution bit.

When lpsetup is installed, the script lpsetup/bin/launchpad-database-setup loses its execution bit when put into the egg which results in a permission error when it is invoked.

It looks like there is a bug in the installer (acknowledged but not fixed). The easiest work-around is to just call it via invoking /bin/sh on the script instead.

[Benji York (benji)]

This is OK, I suppose. It does worry met that if the shebang ever
changes to another shell -- say /bin/bash -- and the script takes
advantage of non-sh features, then this could break in mysterious ways
(and the script when run stand-alone will still work, adding to the
mystery).

I wonder if it is worth reading the first line of the script (at
execution time) to assert that it really should be run with /bin/sh.

review: Approve (code)

[Brad Crittenden (bac)]

Good point Benji. Rather than do what you suggest long-term, I think it wiser to just figure out how to make setup.py not drop the execute bit. After discussion with you decided to land this branch with the risk you pointed out.

=== modified file 'lpsetup/subcommands/init_target.py'
--- lpsetup/subcommands/init_target.py	2012-08-22 16:48:50 +0000
+++ lpsetup/subcommands/init_target.py	2012-08-24 18:55:23 +0000
@@ -269,7 +269,7 @@
         script_name = 'launchpad-database-setup'
         here = os.path.dirname(__file__)
         script_path = os.path.join(here, '..', 'bin', script_name)
-        call(script_path, user)
+        call('/bin/sh', script_path, user)
 
 setup_database.description = """Setup database for Launchpad use."""