Merge lp:~bac/lpsetup/stub-lp into lp:lpsetup
Status: | Merged |
---|---|
Approved by: | Brad Crittenden |
Approved revision: | 71 |
Merged at revision: | 64 |
Proposed branch: | lp:~bac/lpsetup/stub-lp |
Merge into: | lp:lpsetup |
Diff against target: |
96 lines (+27/-23) 3 files modified
README.rst (+6/-16) bin/setup-host-for-nested-lxc-containers.sh (+7/-0) lpsetup/tests/integration/test_install_lxc.py (+14/-7) |
To merge this branch: | bzr merge lp:~bac/lpsetup/stub-lp |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Benji York (community) | code | Approve | |
Review via email: mp+117319@code.launchpad.net |
Commit message
Use a stub version of Launchpad for integration testing to avoid the hit for having to download the source branch.
Description of the change
This branch makes the lpsetup test_install_lxc.py integration test check out and use a fake Launchpad branch, so that the test can run faster.
A recent run completed in 22 minutes on my development machine.
The branch it checks out is at lp:~yellow/launchpad/stub. It only has the referenced three scripts in utilities and the minimal targets required for the Makefile. Gary suggested that the utility scripts actually touch a file to demonstrate they did something but I didn't see that doing so would be too helpful. We can add that in if it ever becomes useful.
This branch looks good. As we discussed on IRC the README should mention bin/setup- host-for- nested- lxc-containers. sh