Merge lp:~bac/lpsetup/install-lxc-rename into lp:lpsetup

Proposed by Brad Crittenden
Status: Merged
Approved by: Gary Poster
Approved revision: 47
Merged at revision: 47
Proposed branch: lp:~bac/lpsetup/install-lxc-rename
Merge into: lp:lpsetup
Diff against target: 105 lines (+13/-13)
4 files modified
lpsetup/cli.py (+2/-2)
lpsetup/subcommands/finish_inithost.py (+2/-2)
lpsetup/tests/subcommands/test_finish_inithost.py (+2/-2)
lpsetup/tests/subcommands/test_install_lxc.py (+7/-7)
To merge this branch: bzr merge lp:~bac/lpsetup/install-lxc-rename
Reviewer Review Type Date Requested Status
Gary Poster (community) Approve
Review via email: mp+113992@code.launchpad.net

Commit message

Rename lxc-install to install-lxc.

Description of the change

Rename lxc-install to install-lxc.

To post a comment you must log in.
Revision history for this message
Gary Poster (gary) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lpsetup/cli.py'
2--- lpsetup/cli.py 2012-07-06 19:18:58 +0000
3+++ lpsetup/cli.py 2012-07-09 15:32:22 +0000
4@@ -20,7 +20,7 @@
5 inithost,
6 initlxc,
7 initrepo,
8- lxcinstall,
9+ install_lxc,
10 update,
11 version,
12 )
13@@ -31,7 +31,7 @@
14 ('init-host', inithost.SubCommand),
15 ('init-lxc', initlxc.SubCommand),
16 ('init-repo', initrepo.SubCommand),
17- ('lxc-install', lxcinstall.SubCommand),
18+ ('install-lxc', install_lxc.SubCommand),
19 ('update', update.SubCommand),
20 ('version', version.SubCommand),
21 ]
22
23=== modified file 'lpsetup/subcommands/finish_inithost.py'
24--- lpsetup/subcommands/finish_inithost.py 2012-07-06 14:59:07 +0000
25+++ lpsetup/subcommands/finish_inithost.py 2012-07-09 15:32:22 +0000
26@@ -99,10 +99,10 @@
27 def steps(self):
28 # Break import loop (and break it here because this subcommand is
29 # going away soon).
30- import lxcinstall
31+ import install_lxc
32 return (
33 inithost.SubCommand.initialize_step,
34- lxcinstall.SubCommand.fetch_step,
35+ install_lxc.SubCommand.fetch_step,
36 (setup_bzr_locations_as_root,
37 'user', 'lpuser', 'repository'),
38 inithost.SubCommand.setup_apt_step,
39
40=== renamed file 'lpsetup/subcommands/lxcinstall.py' => 'lpsetup/subcommands/install_lxc.py'
41=== modified file 'lpsetup/tests/subcommands/test_finish_inithost.py'
42--- lpsetup/tests/subcommands/test_finish_inithost.py 2012-07-06 14:59:07 +0000
43+++ lpsetup/tests/subcommands/test_finish_inithost.py 2012-07-09 15:32:22 +0000
44@@ -44,10 +44,10 @@
45
46 @property
47 def expected_steps(self):
48- from lpsetup.tests.subcommands import test_lxcinstall
49+ from lpsetup.tests.subcommands import test_install_lxc
50 return (
51 test_inithost.initialize_step,
52- test_lxcinstall.fetch_step,
53+ test_install_lxc.fetch_step,
54 setup_bzr_locations_step,
55 test_inithost.setup_apt_step,
56 setup_launchpad_step,
57
58=== renamed file 'lpsetup/tests/subcommands/test_lxcinstall.py' => 'lpsetup/tests/subcommands/test_install_lxc.py'
59--- lpsetup/tests/subcommands/test_lxcinstall.py 2012-07-05 18:38:51 +0000
60+++ lpsetup/tests/subcommands/test_install_lxc.py 2012-07-09 15:32:22 +0000
61@@ -2,12 +2,12 @@
62 # Copyright 2012 Canonical Ltd. This software is licensed under the
63 # GNU Affero General Public License version 3 (see the file LICENSE).
64
65-"""Tests for the lxcinstall sub command."""
66+"""Tests for the install-lxc sub command."""
67
68 import unittest
69
70 from lpsetup import handlers
71-from lpsetup.subcommands import lxcinstall
72+from lpsetup.subcommands import install_lxc
73 from lpsetup.tests.subcommands import (
74 test_inithost,
75 test_initlxc,
76@@ -19,14 +19,14 @@
77
78
79 fetch_step = (
80- lxcinstall.fetch, ['user', 'repository', 'dependencies_dir',
81+ install_lxc.fetch, ['user', 'repository', 'dependencies_dir',
82 'valid_ssh_keys'])
83 create_scripts_step = (
84- lxcinstall.create_scripts, ['lxc_name', 'ssh_key_path', 'user'])
85+ install_lxc.create_scripts, ['lxc_name', 'ssh_key_path', 'user'])
86 create_lxc_callable, create_lxc_args = test_initlxc.create_lxc_step
87 create_lxc_step = (create_lxc_callable, create_lxc_args + ['install_subunit'])
88 setup_lxc_step = (
89- lxcinstall.setup_lxc, ['lxc_name', 'ssh_key_path', 'user',
90+ install_lxc.setup_lxc, ['lxc_name', 'ssh_key_path', 'user',
91 'dependencies_dir', 'repository'])
92
93
94@@ -39,9 +39,9 @@
95 )
96
97
98-class LxcInstallTest(StepsBasedSubCommandTestMixin, unittest.TestCase):
99+class InstallLxcTest(StepsBasedSubCommandTestMixin, unittest.TestCase):
100
101- sub_command_class = lxcinstall.SubCommand
102+ sub_command_class = install_lxc.SubCommand
103 expected_arguments = get_arguments()
104 expected_handlers = (
105 handlers.handle_user,

Subscribers

People subscribed via source and target branches