Merge lp:~bac/launchpad/productseries-js into lp:launchpad

[Brad Crittenden]

Provide javascript to control the behavior on the new productseries/+setbranch page.

= Summary =

While fixing bug 524302 functionality from several pages will be combined to provide
an unified view of branch creation/importing/mirroring. The page needs some JS logic
to control the select enabling of the various fields based on the state of radiobuttons.

This branch provides that JS and the tests for it only.

== Proposed fix ==

Create a new JS module to control the status of the page elements based on the
radiobuttons.

== Pre-implementation notes ==

Long discussions with Curtis during our sprint.

== Implementation details ==

As above.

== Tests ==

Load lib/canonical/launchpad/javascript/registry/tests/productseries-setbranch.html
into a browser and ensure all tests pass.

== Demo and Q/A ==

N/A

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/canonical/launchpad/javascript/registry/tests/productseries-setbranch.html
  lib/canonical/launchpad/javascript/registry/productseries-setbranch.js
  lib/canonical/launchpad/javascript/registry/tests/test_productseries_setbranch.js

== JSLint notices ==
jslint: Lint found in
'/home/bac/canonical/lp-branches/productseries-js/lib/canonical/launchpad/javascript/registry/productseries-setbranch.js':
Line 84 character 22: 'rcs_types' is already defined.
       var rcs_types = module._rcs_types();

jslint: No problem found in
'/home/bac/canonical/lp-branches/productseries-js/lib/canonical/launchpad/javascript/registry/tests/test_productseries_setbranch.js'.

jslint: 2 files to lint.

I'll take care of these lint issues before landing.

[Curtis Hovey (sinzui)]

This is a very good start Brad. I have some concerns about using the underlying js engine. I
have some proposals that use YUI to minimise engine problems. There are some style issue I think
need fixing too. The test is very nice, and it will prove useful when refactoring some of this
library.

> === added file 'lib/canonical/launchpad/javascript/registry/productseries-setbranch.js'
> --- lib/canonical/launchpad/javascript/registry/productseries-setbranch.js 1970-01-01 00:00:00 +0000
> +++ lib/canonical/launchpad/javascript/registry/productseries-setbranch.js 2010-03-16 20:32:39 +0000
> @@ -0,0 +1,93 @@
> +/* Copyright 2010 Canonical Ltd. This software is licensed under the
> + * GNU Affero General Public License version 3 (see the file LICENSE).
> + *
> + * Control enabling/disabling of complex form on the
> + * productseries/+setbranch page.
> + *
> + * @module Y.registry.productseries_setbranch
> + * @requires node
> + */

This module require DOM too.

Is registry the correct location for this script? I think the code module
may be better. Consider a project that will never have code/branches; this
code will never be used. I think the code and bug configurations belong in
their respective apps. My test for placing code in registry is to ask
what happens if the app is removed? If we remove Launchpad Code, this
script would have to be removed in a separate effort.

> +YUI.add('registry.productseries_setbranch', function(Y) {
> + Y.log('loading registry.productseries_setbranch');
> + var module = Y.namespace('registry.productseries_setbranch');
> +
> + module._getSelectedRCS = function() {

We use PEP 8 for function and method names. These names should be lower
case with underscores. When you see someone setting a module method with
studlyCaps, it is probably because that method is defined in a prototype
or event.

Review all your method names.

> + var rcs_types = module._rcs_types();
> + var selected = 'None';
> + for (var i = 0; i < rcs_types.length; i++) {
> + if (rcs_types[i].checked) {
> + selected = rcs_types[i].value;
> + break;
> + }
> + }
> + return selected;
> + };
> +
> + module.__rcs_types = null;
> +
> + module._rcs_types = function() {
> + if (module.__rcs_types === null) {
> + module.__rcs_types = document.getElementsByName('field.rcs_type');
> + }
> + return module.__rcs_types;
> + };
> +
> + module.setEnabled = function(field_id, is_enabled) {
> + var field = Y.DOM.byId(field_id);
> + field.disabled = !is_enabled;
> + };
> +
> + module.onclickRcsType = function() {
> + /* Which rcs type radio button has been selected? */
> + // CVS
> + var rcs_types = module._rcs_types();
> + var selectedRCS = module._getSelectedRCS();
> + module.setEnabled('field.cvs_module', selectedRCS == 'CVS');
> + };

Event handler functions receive an event argument, traditionally named 'e'

    module.onclick_rcs_type = function(e) {

You need to update all of these methods, though you are not required to
use e, so no other changes are needed.

> + module.onclickBranchType = f...

review: Needs Fixing (js)

[Brad Crittenden (bac)]

Thanks for the review Curtis and your help with the testing issues.

I've incorporated all of your suggestions, cleaned up the testing, and added support for two new fields: branch_name and branch_owner.

Incremental diff at http://pastebin.ubuntu.com/397846/

[Curtis Hovey (sinzui)]

This looks good to land, but I ask that you refrain until YUI unittests run automatically.

> === renamed file 'lib/canonical/launchpad/javascript/registry/productseries-setbranch.js' => 'lib/canonical/launchpad/javascript/code/productseries-setbranch.js'
> --- lib/canonical/launchpad/javascript/registry/productseries-setbranch.js 2010-03-15 21:13:23 +0000
> +++ lib/canonical/launchpad/javascript/code/productseries-setbranch.js 2010-03-19 13:35:15 +0000
...
> + module.setup = function() {
> + Y.all('input[name=field.rcs_type]').each(function(field) {
> + field.on('click', module.onclick_rcs_type);});
> + Y.all('input[name=field.branch_type]').each(function(field) {
> + field.on('click', module.onclick_branch_type);});

I think these could use the ListNode.on() method to make the code a little
easier to read.

        Y.all('input[name=field.rcs_type]').on(
            'click', module.onclick_rcs_type);
        Y.all('input[name=field.branch_type]').on(
            'click', module.onclick_branch_type);
...

> === renamed file 'lib/canonical/launchpad/javascript/registry/tests/test_productseries_setbranch.js' => 'lib/canonical/launchpad/javascript/code/tests/test_productseries_setbranch.js'
> --- lib/canonical/launchpad/javascript/registry/tests/test_productseries_setbranch.js 2010-03-15 21:13:23 +0000
> +++ lib/canonical/launchpad/javascript/code/tests/test_productseries_setbranch.js 2010-03-19 14:29:27 +0000
...
> @@ -48,31 +50,50 @@
>
> tearDown: function() {
> delete this.tbody;
> - },
> + },
>
> test_handlers_connected: function() {
> - Y.Assert.areEqual('onclickBranchType()',
> - this.link_lp_bzr.getAttribute('onclick'),
> - 'branch type onclick handler not correct');
> - Y.Assert.areEqual('onclickBranchType()',
> - this.create_new.getAttribute('onclick'),
> - 'branch type onclick handler not correct');
> - Y.Assert.areEqual('onclickBranchType()',
> - this.import_external.getAttribute('onclick'),
> - 'branch type onclick handler not correct');
> -
> + // Manually invoke the setup function to ensure the handlers are set.+ module.setup();

Wrap the code at 78 characters.
...

@@ -202,7 +234,8 @@
     var console = new Y.Console({newestOnTop: false});
     console.render('#log');

- Y.on('domready', function() {
+ // Start the test runner on Y.after to ensure all setup has had a chance to complete.

Wrap the code at 78 characters.
...

review: Approve (js)

[Curtis Hovey (sinzui)]

review: Approve (js and code)

=== added file 'lib/lp/code/javascript/productseries-setbranch.js'
--- lib/lp/code/javascript/productseries-setbranch.js	1970-01-01 00:00:00 +0000
+++ lib/lp/code/javascript/productseries-setbranch.js	2010-04-05 23:04:33 +0000
@@ -0,0 +1,88 @@
+/* Copyright 2010 Canonical Ltd.  This software is licensed under the
+ * GNU Affero General Public License version 3 (see the file LICENSE).
+ *
+ * Control enabling/disabling of complex form on the
+ * productseries/+setbranch page.
+ *
+ * @module Y.lp.code.productseries_setbranch
+ * @requires node, DOM
+ */
+YUI.add('lp.code.productseries_setbranch', function(Y) {
+    Y.log('loading lp.code.productseries_setbranch');
+    var module = Y.namespace('lp.code.productseries_setbranch');
+
+    module._get_selected_rcs = function() {
+       var rcs_types = module._rcs_types();
+       var selected = 'None';
+       for (var i = 0; i < rcs_types.length; i++) {
+          if (rcs_types[i].checked) {
+             selected = rcs_types[i].value;
+             break;
+          }
+       }
+       return selected;
+    };
+
+
+    module.__rcs_types = null;
+
+    module._rcs_types = function() {
+       if (module.__rcs_types === null) {
+          module.__rcs_types = document.getElementsByName('field.rcs_type');
+       }
+       return module.__rcs_types;
+    };
+
+    module.set_enabled = function(field_id, is_enabled) {
+       var field = Y.DOM.byId(field_id);
+       field.disabled = !is_enabled;
+    };
+
+    module.onclick_rcs_type = function(e) {
+       /* Which rcs type radio button has been selected? */
+       // CVS
+       var rcs_types = module._rcs_types();
+       var selectedRCS = module._get_selected_rcs();
+       module.set_enabled('field.cvs_module', selectedRCS == 'CVS');
+    };
+
+    module.onclick_branch_type = function(e) {
+       /* Which branch type radio button was selected? */
+       var selectedRCS = module._get_selected_rcs();
+       var types = document.getElementsByName('field.branch_type');
+       var type = 'None';
+       for (var i = 0; i < types.length; i++) {
+          if (types[i].checked) {
+             type = types[i].value;
+             break;
+          }
+       }
+       // Linked
+       module.set_enabled('field.branch_location', type == 'link-lp-bzr');
+       module.set_enabled('field.branch_name', type != 'link-lp-bzr');
+       module.set_enabled('field.branch_owner', type != 'link-lp-bzr');
+       // New, empty branch.
+       // Import
+       var is_external = (type == 'import-external');
+       module.set_enabled('field.repo_url', is_external);
+       module.set_enabled('field.cvs_module',
+                   (is_external & selectedRCS == 'CVS'));
+       var rcs_types = module._rcs_types();
+       for (var j = 0; j < rcs_types.length; j++) {
+          rcs_types[j].disabled = !is_external;
+       }
+    };
+
+    module.setup = function() {
+       Y.all('input[name=field.rcs_type]').on(
+          'click', module.onclick_rcs_type);
+       Y.all('input[name=field.branch_type]').on(
+          'click', module.onclick_branch_type);
+
+       // Set the initial state.
+       module.onclick_rcs_type();
+       module.onclick_branch_type();
+    };
+
+   }, "0.1", {"requires": ["node", "DOM"]}
+);

=== added file 'lib/lp/code/javascript/tests/test_productseries-setbranch.html'
--- lib/lp/code/javascript/tests/test_productseries-setbranch.html	1970-01-01 00:00:00 +0000
+++ lib/lp/code/javascript/tests/test_productseries-setbranch.html	2010-04-05 23:04:33 +0000
@@ -0,0 +1,213 @@
+<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01//EN" "http://www.w3.org/TR/html4/strict.dtd">
+
+<html>
+  <head>
+  <title>stroppy trunk series : Series trunk : stroppy</title>
+
+  <!-- YUI 3.0 Setup -->
+  <script type="text/javascript" src="../../../../canonical/launchpad/icing/yui/yui/yui.js"></script>
+  <script type="text/javascript" src="../../../../canonical/launchpad/icing/lazr/build/lazr.js"></script>
+  <link rel="stylesheet" href="../../../../canonical/launchpad/icing/yui/cssreset/reset.css"/>
+  <link rel="stylesheet" href="../../../../canonical/launchpad/icing/yui/cssfonts/fonts.css"/>
+  <link rel="stylesheet" href="../../../../canonical/launchpad/icing/yui/cssbase/base.css"/>
+  <link rel="stylesheet" href="../../../../canonical/launchpad/javascript/test.css" />
+  <script type="text/javascript" src="../../../../canonical/launchpad/lp/lp.js"></script>
+
+  <!-- The module under test -->
+  <script type="text/javascript" src="../productseries-setbranch.js"></script>
+  <script type="text/javascript">
+    YUI().use('lp.code.productseries_setbranch', function(Y) {
+      Y.on('domready', Y.lp.code.productseries_setbranch.setup);
+    });
+  </script>
+
+  <!-- The test suite -->
+  <script type="text/javascript" src="test_productseries_setbranch.js"></script>
+  </head>
+
+<body class="yui-skin-sam">
+  <div id="productseries-setbranch">
+  <form action="." name="launchpadform" method="post"
+        enctype="multipart/form-data"
+        accept-charset="UTF-8">
+
+    <table class="form">
+      <tbody>
+        <tr>
+          <td>
+            <label>
+              <input class="radioType" checked="checked"
+                     id="field.branch_type.0"
+                     name="field.branch_type" type="radio" value="link-lp-bzr">
+              Link to a Bazaar branch already in Launchpad
+            </label>
+              <table>
+                <tbody>
+                  <tr>
+                    <td colspan="2">
+                      <label for="field.branch_location">Branch:</label>
+                      <span class="fieldRequired">(Optional)</span>
+                      <div>
+                        <input type="text" value="" id="field.branch_location"
+                               name="field.branch_location" size="35">
+
+                      </div>
+                      <p class="formHelp">The Bazaar branch for this series in
+                        Launchpad, if one exists.</p>
+                    </td>
+                  </tr>
+              </tbody>
+              </table>
+          </td>
+        </tr>
+
+        <tr>
+          <td>
+            <label>
+              <input class="radioType" id="field.branch_type.1"
+                     name="field.branch_type"
+                     type="radio" value="create-new">
+              Create a new, empty branch in Launchpad and link
+              to this series
+            </label>
+          </td>
+        </tr>
+
+        <tr>
+          <td>
+            <label>
+              <input class="radioType" id="field.branch_type.2"
+                     name="field.branch_type" type="radio"
+                     value="import-external">
+              Import a branch hosted somewhere else
+            </label>
+            <table>
+              <tbody>
+                <tr>
+                  <td colspan="2">
+                    <label for="field.repo_url">Branch URL:</label>
+                    <span class="fieldRequired">(Optional)</span>
+                    <div>
+                      <input class="urlTextType textType" id="field.repo_url"
+                             name="field.repo_url" size="44" type="text"
+                             value="" disabled="">
+                    </div>
+                  </td>
+                </tr>
+
+                <tr>
+                  <td>
+                    <label>
+                      <input class="radioType" id="field.rcs_type.6"
+                             name="field.rcs_type" type="radio" value="BZR"
+                             disabled="">
+                      Bazaar, hosted externally
+                    </label>
+                  </td>
+                </tr>
+
+                <tr>
+                  <td>
+                    <label>
+                      <input class="radioType" id="field.rcs_type.4"
+                             name="field.rcs_type" type="radio" value="GIT"
+                             disabled="">
+                      Git
+                    </label>
+                  </td>
+                </tr>
+
+                <tr>
+                  <td>
+                    <label>
+                      <input class="radioType" id="field.rcs_type.3"
+                             name="field.rcs_type" type="radio"
+                             value="BZR_SVN" disabled="">
+                      SVN
+                    </label>
+                  </td>
+                </tr>
+
+                <tr>
+                  <td>
+                    <label>
+                      <input class="radioType" id="field.rcs_type.5"
+                             name="field.rcs_type" type="radio" value="HG" disabled="">
+                      Mercurial
+                    </label>
+                  </td>
+                </tr>
+
+                <tr>
+                  <td>
+                    <label>
+                      <input class="radioType" id="field.rcs_type.1"
+                             name="field.rcs_type" type="radio" value="CVS"
+                             disabled="">
+                      CVS
+                    </label>
+
+                    <table>
+                      <tbody>
+                        <tr>
+                          <td colspan="2">
+                            <label for="field.cvs_module">Module:</label>
+                            <span class="fieldRequired">(Optional)</span>
+
+                            <div>
+                              <input class="textType" id="field.cvs_module"
+                                     name="field.cvs_module" size="20"
+                                     type="text"
+                                     value="" disabled="">
+                            </div>
+                          </td>
+                        </tr>
+                      </tbody>
+                    </table>
+                  </td>
+                </tr>
+              </tbody>
+            </table>
+          </td>
+        </tr>
+
+        <tr>
+          <td colspan="2">
+            <label for="field.branch_name">Branch name:</label>
+            <div>
+              <input class="textType" id="field.branch_name" name="field.branch_name" size="20" type="text" value=""  />
+            </div>
+          </td>
+        </tr>
+
+        <tr>
+          <td colspan="2">
+            <label for="field.branch_owner">Branch owner:</label>
+            <div>
+              <div class="value">
+                <select id="field.branch_owner" name="field.branch_owner" size="1" >
+                  <option value="mark">Mark Shuttleworth (mark)</option>
+                  <option value="guadamen">GuadaMen (guadamen)</option>
+                  <option value="hwdb-team">HWDB Team (hwdb-team)</option>
+                  <option value="admins">Launchpad Administrators (admins)</option>
+                  <option value="mailing-list-experts">Mailing List Experts (mailing-list-experts)</option>
+                  <option value="ubuntu-mirror-admins">Mirror Administrators (ubuntu-mirror-admins)</option>
+                  <option value="registry">Registry Administrators (registry)</option>
+                  <option value="testing-spanish-team">testing Spanish team (testing-spanish-team)</option>
+                  <option value="ubuntu-team">Ubuntu Team (ubuntu-team)</option>
+                </select>
+              </div>
+              <input name="field.branch_owner-empty-marker" type="hidden" value="1" />
+            </div>
+          </td>
+        </tr>
+      </tbody>
+    </table>
+    <input type="submit" id="field.actions.update"
+           name="field.actions.update" value="Update" class="button">
+    or&nbsp;
+    <a href="https://launchpad.dev/zyc/trunk">Cancel</a>
+  </form>
+  </div>
+</body>
+</html>

=== added file 'lib/lp/code/javascript/tests/test_productseries_setbranch.js'
--- lib/lp/code/javascript/tests/test_productseries_setbranch.js	1970-01-01 00:00:00 +0000
+++ lib/lp/code/javascript/tests/test_productseries_setbranch.js	2010-04-05 23:04:33 +0000
@@ -0,0 +1,249 @@
+/* Copyright 2010 Canonical Ltd.  This software is licensed under the
+ * GNU Affero General Public License version 3 (see the file LICENSE).
+ *
+ * Test driver for productseries_setbranch.js.
+ *
+ */
+
+YUI({
+    base: '../../../../canonical/launchpad/icing/yui/',
+    filter: 'raw', combine: false
+    }).use('node-event-simulate', 'test', 'console', 'Event', 'CustomEvent',
+           'lp.code.productseries_setbranch', function(Y) {
+
+    var module = Y.lp.code.productseries_setbranch;
+    var suite = new Y.Test.Suite("productseries_setbranch Tests");
+
+    suite.add(new Y.Test.Case({
+        // Test the onclick results.
+        name: 'select_branchtype',
+
+        _should: {
+            error: {
+                //test_config_undefined: true,
+                //test_missing_tbody_is_an_error: true
+                }
+        },
+
+        setUp: function() {
+           this.tbody = Y.one('#productseries-setbranch');
+
+           // Get the individual branch type radio buttons.
+           this.link_lp_bzr = Y.DOM.byId('field.branch_type.0');
+           this.create_new = Y.DOM.byId('field.branch_type.1');
+           this.import_external = Y.DOM.byId('field.branch_type.2');
+
+           // Get the input widgets.
+           this.branch_location = Y.DOM.byId('field.branch_location');
+           this.cvs_module = Y.DOM.byId('field.cvs_module');
+           this.repo_url = Y.DOM.byId('field.repo_url');
+           this.branch_name = Y.DOM.byId('field.branch_name');
+           this.branch_owner = Y.DOM.byId('field.branch_owner');
+
+           // Get the individual rcs type radio buttons.
+           this.cvs = Y.DOM.byId('field.rcs_type.1');
+           this.svn = Y.DOM.byId('field.rcs_type.3');
+           this.git = Y.DOM.byId('field.rcs_type.4');
+           this.hg = Y.DOM.byId('field.rcs_type.5');
+           this.bzr = Y.DOM.byId('field.rcs_type.6');
+        },
+
+        tearDown: function() {
+            delete this.tbody;
+        },
+
+        test_handlers_connected: function() {
+           // Manually invoke the setup function to ensure the handlers are
+           // set.
+           module.setup();
+
+           var check_handler = function(field, expected) {
+              var custom_events = Y.Event.getListeners(field, 'click');
+              var click_event = custom_events[0];
+              var subscribers = click_event.subscribers;
+              for (var sub in subscribers) {
+                 Y.Assert.isTrue(subscribers[sub].contains(expected),
+                                 'branch_type_onclick handler setup');
+              };
+           };
+
+           check_handler(this.link_lp_bzr, module.onclick_branch_type);
+           check_handler(this.create_new, module.onclick_branch_type);
+           check_handler(this.import_external, module.onclick_branch_type);
+
+           check_handler(this.cvs, module.onclick_rcs_type);
+           check_handler(this.svn, module.onclick_rcs_type);
+           check_handler(this.git, module.onclick_rcs_type);
+           check_handler(this.hg, module.onclick_rcs_type);
+           check_handler(this.bzr, module.onclick_rcs_type);
+        },
+
+        test_select_link_lp_bzr: function() {
+           this.link_lp_bzr.checked = true;
+           module.onclick_branch_type();
+           // The branch location is enabled.
+           Y.Assert.isFalse(this.branch_location.disabled,
+                            'branch_location disabled');
+           module.onclick_rcs_type();
+           // The CVS module and repo url are disabled.
+           Y.Assert.isTrue(this.cvs_module.disabled,
+                           'cvs_module not disabled');
+           Y.Assert.isTrue(this.repo_url.disabled,
+                           'repo_url not disabled');
+           // The branch name and owner are disabled.
+           Y.Assert.isTrue(this.branch_name.disabled,
+                           'branch_name not disabled');
+           Y.Assert.isTrue(this.branch_owner.disabled,
+                           'branch_owner not disabled');
+           // All of the radio buttons are disabled.
+           Y.Assert.isTrue(this.cvs.disabled,
+                           'cvs button not disabled');
+           Y.Assert.isTrue(this.svn.disabled,
+                           'svn button not disabled');
+           Y.Assert.isTrue(this.git.disabled,
+                           'git button not disabled');
+           Y.Assert.isTrue(this.hg.disabled,
+                           'hg button not disabled');
+           Y.Assert.isTrue(this.bzr.disabled,
+                           'bzr button not disabled');
+        },
+
+        test_select_create_new: function() {
+           this.create_new.checked = true;
+           module.onclick_branch_type();
+           // The branch location is disabled.
+           Y.Assert.isTrue(this.branch_location.disabled,
+                           'branch_location not disabled');
+           module.onclick_rcs_type();
+           // The CVS module and repo url are disabled.
+           Y.Assert.isTrue(this.cvs_module.disabled,
+                           'cvs_module not disabled');
+           Y.Assert.isTrue(this.repo_url.disabled,
+                           'repo_url not disabled');
+           // The branch name and owner are enabled.
+           Y.Assert.isFalse(this.branch_name.disabled,
+                           'branch_name disabled');
+           Y.Assert.isFalse(this.branch_owner.disabled,
+                           'branch_owner disabled');
+           // All of the radio buttons are disabled.
+           Y.Assert.isTrue(this.cvs.disabled,
+                           'cvs button not disabled');
+           Y.Assert.isTrue(this.svn.disabled,
+                           'svn button not disabled');
+           Y.Assert.isTrue(this.git.disabled,
+                           'git button not disabled');
+           Y.Assert.isTrue(this.hg.disabled,
+                           'hg button not disabled');
+           Y.Assert.isTrue(this.bzr.disabled,
+                           'bzr button not disabled');
+        },
+
+        test_select_import_external: function() {
+           this.import_external.checked = true;
+           module.onclick_branch_type();
+           // The branch location is disabled.
+           Y.Assert.isTrue(this.branch_location.disabled,
+                           'branch_location not disabled');
+           // The repo url is enabled.
+           Y.Assert.isFalse(this.repo_url.disabled,
+                           'repo_url disabled');
+           module.onclick_rcs_type();
+           // The branch name and owner are enabled.
+           Y.Assert.isFalse(this.branch_name.disabled,
+                           'branch_name disabled');
+           Y.Assert.isFalse(this.branch_owner.disabled,
+                           'branch_owner disabled');
+           // All of the radio buttons are disabled.
+           Y.Assert.isFalse(this.cvs.disabled,
+                           'cvs button disabled');
+           Y.Assert.isFalse(this.svn.disabled,
+                           'svn button disabled');
+           Y.Assert.isFalse(this.git.disabled,
+                           'git button disabled');
+           Y.Assert.isFalse(this.hg.disabled,
+                           'hg button disabled');
+           Y.Assert.isFalse(this.bzr.disabled,
+                           'bzr button disabled');
+
+        },
+
+        test_select_import_external_bzr: function() {
+           this.import_external.checked = true;
+           module.onclick_branch_type();
+           Y.Assert.isFalse(this.repo_url.disabled,
+                           'repo_url disabled');
+           this.bzr.checked = true;
+           module.onclick_rcs_type();
+           // The CVS module input is disabled.
+           Y.Assert.isTrue(this.cvs_module.disabled,
+                           'cvs_module disabled');
+        },
+
+        test_select_import_external_hg: function() {
+           this.import_external.checked = true;
+           module.onclick_branch_type();
+           Y.Assert.isFalse(this.repo_url.disabled,
+                           'repo_url disabled');
+           this.hg.checked = true;
+           module.onclick_rcs_type();
+           // The CVS module input is disabled.
+           Y.Assert.isTrue(this.cvs_module.disabled,
+                           'cvs_module disabled');
+        },
+
+        test_select_import_external_git: function() {
+           this.import_external.checked = true;
+           module.onclick_branch_type();
+           Y.Assert.isFalse(this.repo_url.disabled,
+                           'repo_url disabled');
+           this.git.checked = true;
+           module.onclick_rcs_type();
+           // The CVS module input is disabled.
+           Y.Assert.isTrue(this.cvs_module.disabled,
+                           'cvs_module disabled');
+        },
+
+        test_select_import_external_svn: function() {
+           this.import_external.checked = true;
+           module.onclick_branch_type();
+           Y.Assert.isFalse(this.repo_url.disabled,
+                           'repo_url disabled');
+           this.svn.checked = true;
+           module.onclick_rcs_type();
+           // The CVS module input is disabled.
+           Y.Assert.isTrue(this.cvs_module.disabled,
+                           'cvs_module disabled');
+        },
+
+        test_select_import_external_cvs: function() {
+           this.import_external.checked = true;
+           module.onclick_branch_type();
+           Y.Assert.isFalse(this.repo_url.disabled,
+                           'repo_url disabled');
+           this.cvs.checked = true;
+           module.onclick_rcs_type();
+           // The CVS module input is enabled
+           Y.Assert.isFalse(this.cvs_module.disabled,
+                           'cvs_module disabled');
+        }
+
+        }));
+
+    // Lock, stock, and two smoking barrels.
+    var handle_complete = function(data) {
+        status_node = Y.Node.create(
+            '<p id="complete">Test status: complete</p>');
+        Y.get('body').appendChild(status_node);
+        };
+    Y.Test.Runner.on('complete', handle_complete);
+    Y.Test.Runner.add(suite);
+
+    var console = new Y.Console({newestOnTop: false});
+    console.render('#log');
+
+    // Start the test runner on Y.after to ensure all setup has had a
+    // chance to complete.
+    Y.after('domready', function() {
+        Y.Test.Runner.run();
+    });
+});

=== added file 'lib/lp/code/windmill/tests/test_yuitests.py'
--- lib/lp/code/windmill/tests/test_yuitests.py	1970-01-01 00:00:00 +0000
+++ lib/lp/code/windmill/tests/test_yuitests.py	2010-04-05 23:04:33 +0000
@@ -0,0 +1,21 @@
+# Copyright 2010 Canonical Ltd.  This software is licensed under the
+# GNU Affero General Public License version 3 (see the file LICENSE).
+
+"""Run YUI.test tests."""
+
+__metaclass__ = type
+__all__ = []
+
+from lp.testing import build_yui_unittest_suite, YUIUnitTestCase
+from lp.code.windmill.testing import CodeWindmillLayer
+
+
+class CodeYUIUnitTestCase(YUIUnitTestCase):
+
+    layer = CodeWindmillLayer
+    suite_name = 'CodeYUIUnitTests'
+
+
+def test_suite():
+    app_testing_path = 'lp/code/javascript/tests'
+    return build_yui_unittest_suite(app_testing_path, CodeYUIUnitTestCase)