Merge lp:~bac/launchpad/person-in-team into lp:launchpad
Status: | Merged |
---|---|
Approved by: | Brad Crittenden |
Approved revision: | no longer in the source branch. |
Merged at revision: | 12732 |
Proposed branch: | lp:~bac/launchpad/person-in-team |
Merge into: | lp:launchpad |
Diff against target: |
37 lines (+5/-11) 1 file modified
lib/lp/bugs/browser/structuralsubscription.py (+5/-11) |
To merge this branch: | bzr merge lp:~bac/launchpad/person-in-team |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Benji York (community) | code | Approve | |
Review via email: mp+55928@code.launchpad.net |
Commit message
[r=benji][no-qa] Replace person_
Description of the change
= Summary =
The implementation of person_
and this fix *seems* to be better. Lots of hand waving here.
== Proposed fix ==
Get all of a users administered teams in one query and just check each
one subsequently.
== Pre-implementation notes ==
None
== Implementation details ==
As above.
== Tests ==
No test changes as test_expose seems to have good coverage and it is
just a reimplementation of existing functionality.
== Demo and Q/A ==
None
= Launchpad lint =
Checking for conflicts and issues in changed files.
Linting changed files:
lib/lp/
Looks good.
Agreed regarding tests, this is a pure refactoring so if the existing test coverage is good, we should be fine there.