Merge lp:~bac/launchpad/js-client-link into lp:launchpad
Proposed by
Brad Crittenden
Status: | Merged |
---|---|
Approved by: | Brad Crittenden |
Approved revision: | no longer in the source branch. |
Merged at revision: | 14634 |
Proposed branch: | lp:~bac/launchpad/js-client-link |
Merge into: | lp:launchpad |
Diff against target: |
95 lines (+33/-8) 3 files modified
lib/lp/app/javascript/client.js (+9/-7) lib/lp/app/javascript/tests/test_lp_client_integration.js (+15/-1) lib/lp/app/javascript/tests/test_lp_client_integration.py.disabled (+9/-0) |
To merge this branch: | bzr merge lp:~bac/launchpad/js-client-link |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Benji York (community) | code | Approve | |
Review via email: mp+87532@code.launchpad.net |
Commit message
[r=benji][bug=911973] Set lp_original_uri properly for objects returned by named_get and named_post that have a self_link.
Description of the change
If the object returned by wrap_resource_
should be used as the URI (eventually set as lp_original_uri).
You'll note I added a test to test_lp_
it remains disabled.
To post a comment you must log in.
This looks good. As discussed on IRC, we may be able to remove the wrap_resource functionality that substitutes lp_redirect_ location for the passed in uri.