Merge lp:~bac/launchpad/bug-981114-2 into lp:launchpad
Proposed by
Brad Crittenden
on 2012-04-24
| Status: | Merged |
|---|---|
| Approved by: | Gary Poster on 2012-04-24 |
| Approved revision: | no longer in the source branch. |
| Merged at revision: | 15156 |
| Proposed branch: | lp:~bac/launchpad/bug-981114-2 |
| Merge into: | lp:launchpad |
| Diff against target: | 0 lines |
| To merge this branch: | bzr merge lp:~bac/launchpad/bug-981114-2 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Gary Poster (community) | 2012-04-24 | Approve on 2012-04-24 | |
|
Review via email:
|
|||
Commit Message
Set 'bzr whoami' in tests where needed instead of writing out a /etc/mailname in setuplxc.
Description of the Change
= Summary =
Some tests fail if 'bzr whoami' cannot construct a name. The previous
approach was to have /etc/mailname written by setuplxc. Instead, we
explicitly set 'bzr whoami' in the tests that need it.
== Proposed fix ==
Invoke 'bzr whoami' in the one necessary test.
== Pre-implementation notes ==
Talks with Robert and Gary.
== Implementation details ==
As above.
== Tests ==
bin/test -vvt Celery seems to hit them all.
== Demo and Q/A ==
N/A
= Launchpad lint =
Checking for conflicts and issues in changed files.
Linting changed files:
utilities/
lib/lp/
To post a comment you must log in.
| Gary Poster (gary) wrote : | # |
review:
Approve
Perhaps note in a comment that the test uses an isolated bzr environment, so the whoami setting does not pollute anything?
This looks good to me. If someone would prefer a different way of calling the whoami code (e.g., using bzrlib rather than a system call) it's not me. Thanks, Brad.