Merge lp:~bac/launchpad/bug-974617-2 into lp:launchpad
Status: | Merged |
---|---|
Approved by: | Brad Crittenden |
Approved revision: | no longer in the source branch. |
Merged at revision: | 15157 |
Proposed branch: | lp:~bac/launchpad/bug-974617-2 |
Merge into: | lp:launchpad |
Diff against target: |
95 lines (+20/-21) 2 files modified
lib/lp/services/webapp/tests/test_error.py (+4/-21) lib/lp/testing/fixture.py (+16/-0) |
To merge this branch: | bzr merge lp:~bac/launchpad/bug-974617-2 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Benji York (community) | code | Approve | |
Review via email: mp+103339@code.launchpad.net |
Commit message
Wait for is_running to be true before returning from the PGBouncerTestFi
Description of the change
= Summary =
Our previous attempt to fix this bug, suspected to be caused by the PG
bouncer not really being available even after the PID is written,
didn't work. This approach adds a start method to the test fixture
that waits for the is_running property to be true, instead of
attempting to fetch an URL.
== Proposed fix ==
As above.
== Pre-implementation notes ==
Talks with Gary.
== Implementation details ==
As above.
== Tests ==
bin/test -vvt test_operationa
== Demo and Q/A ==
No QA.
= Launchpad lint =
Checking for conflicts and issues in changed files.
Linting changed files:
lib/lp/
lib/lp/
This branch looks good. It does look like the docstring for start in
fixture.py needs reconciling with reality.