Merge lp:~bac/launchpad/bug-751397 into lp:launchpad
Status: | Merged |
---|---|
Approved by: | Brad Crittenden |
Approved revision: | no longer in the source branch. |
Merged at revision: | 12770 |
Proposed branch: | lp:~bac/launchpad/bug-751397 |
Merge into: | lp:launchpad |
Diff against target: |
315 lines (+74/-45) 9 files modified
lib/lp/app/javascript/client.js (+23/-15) lib/lp/app/javascript/lp.js (+2/-2) lib/lp/app/javascript/tests/test_lp_collapsibles.js (+5/-3) lib/lp/bugs/javascript/filebug_dupefinder.js (+2/-2) lib/lp/bugs/templates/bugtarget-bugs.pt (+17/-14) lib/lp/registry/javascript/structural-subscription.js (+12/-6) lib/lp/registry/javascript/tests/test_structural_subscription.js (+10/-0) lib/lp/soyuz/javascript/lp_dynamic_dom_updater.js (+2/-2) lib/lp/testing/__init__.py (+1/-1) |
To merge this branch: | bzr merge lp:~bac/launchpad/bug-751397 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Deryck Hodge (community) | code | Approve | |
Review via email: mp+56617@code.launchpad.net |
Commit message
[r=deryck][bug=751397] Don't invoke structural-
Description of the change
= Summary =
In YUI3, Y.fail was renamed Y.error so that Y.fail could be moved to the
test infrastructure. Y.fail should no longer be used in production code
but we had many instances of it. They presented no harm in our tests
since the test infrastructure was requiring the 'test' module but in
production Y.fail is undefined and would mask the true error that needed
to be reported.
Also, I do not invoke the structural subscription JS if the bugtarget
does not use LP for bug tracking, which was the point of the original bug.
== Proposed fix ==
s/Y.fail/
== Pre-implementation notes ==
Chat with Deryck.
== Implementation details ==
As above. Also some de-linting, which dominates the diff. Some tests
needed the _should clauses changed from 'fail' to 'error'.
== Tests ==
Windmill tests.
== Demo and Q/A ==
Open https:/
are raised in the console.
= Launchpad lint =
Checking for conflicts and issues in changed files.
Linting changed files:
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
This looks good. Thanks for all the lint cleanup, too.