Merge lp:~bac/launchpad/bug-652149 into lp:launchpad

[Brad Crittenden]

Provide an indication of the default branch visibility rule for a project group and a link to 'Define branch visibility' for LP admins and commercial admins.

= Summary =

The code view for a project group did not show the default branch rules.
 It did have a link for 'Define branch visibility' but the permission on
it was wrong, so commercial admins did not see it.

== Proposed fix ==

Convert the template to main_side, add a portlet for the privacy setting
display and a portlet for the link to define branch visibility.

== Pre-implementation notes ==

Brief chat with Curtis.

== Implementation details ==

I included some drive-by fixes. Removed redundancy from
lp.testing.sampledata and cleaned up the page template for
product-branches to not use conditional paragraphs.

== Tests ==

bin/test -vvm lp.code -t TestProjectGroupBranchesPage

== Demo and Q/A ==

Visit a project group such as https://launchpad.dev/mozilla and
determine everything is in order.

= Launchpad lint =

Bah, I'll check to ensure the real lint issues are fixed.

Checking for conflicts and issues in changed files.

Linting changed files:
  lib/lp/code/templates/project-branches.pt
  lib/lp/code/templates/product-branches.pt
  lib/lp/code/browser/tests/test_branchlisting.py
  lib/lp/testing/sampledata.py
  lib/lp/code/stories/branches/xx-branch-visibility-policy.txt
  lib/lp/registry/browser/project.py
  lib/lp/code/browser/branchlisting.py

./lib/lp/code/stories/branches/xx-branch-visibility-policy.txt
       1: narrative uses a moin header.
      67: source exceeds 78 characters.
      94: narrative uses a moin header.
     104: source exceeds 78 characters.
     107: source exceeds 78 characters.
     125: source exceeds 78 characters.
     126: want exceeds 78 characters.
     134: source exceeds 78 characters.
     138: source exceeds 78 characters.
     146: narrative uses a moin header.
     198: narrative uses a moin header.
     231: source exceeds 78 characters.
     253: source exceeds 78 characters.
./lib/lp/code/browser/branchlisting.py
    1388: E302 expected 2 blank lines, found 1

[lp:~bac/launchpad/bug-652149]

11699. By Brad Crittenden on 2010-10-18

Fixed lint

11700. By Brad Crittenden on 2010-10-18

Fixed lint

[Jeroen T. Vermeulen (jtv)]

Looks fine, apart from a few things we discussed on IRC:
 * Render & search views in your tests using BeautifulSoup(view())
 * Multi-line strings would be nicer than ("line" "line") in tests.
 * The view inherits from both LaunchpadFormView and, indirectly, LaunchpadView.

review: Approve (code)

[Brad Crittenden (bac)]

Thanks Jeroen. All of the issues you raised are fixed.

[lp:~bac/launchpad/bug-652149]

11701. By Brad Crittenden on 2010-10-19

Do not use (expensive) browser in tests, refactor BranchVisiblityPolicyMixin, streamline expected output in tests.

[Brad Crittenden (bac)]

Hi Henning,

Could you do a UI review, please? Screenshots available at:
http://people.canonical.com/~bac/branchvis/

[lp:~bac/launchpad/bug-652149]

11702. By Brad Crittenden on 2010-10-20

Changed display of inherited branch vis policy for projects. Reverted change to product-branches.pt.

[Henning Eggers (henninge)]

Hi Brad,
this looks very good, thank you. The icon misalignment I noticed must be related to other stuff. I see it all over Launchpad now.

I was about to make suggestions about avoiding adding the side portlets and thus losing horizontal space. Horizontal space is a little issue because the project group page has an extra column on the branch listing. The information could be placed in the top portlet but I don't know how long the list of teams might get. Having a long list of team exceptions before reaching the actual branches degrades the usefulness of the page. Maybe the list could have been placed under the branch listing.

But I realized that a project's code page already has that portlet about visibility in the same spot, so I guess this is consistent. IIRC 3.0 UI design removed side portlets from all pages expect project/application home pages?

So the only think I'd like you to think about is if the extra portlet for changing the visibilty. Could that not be integrated into the other portlet by adding an edit icon at the right place?

There is one little nitpick: forbidden-no-teams.png shows some whitespace at the bottom of the upper portlet. This appears on other similar portlets, too, and is owed to the text being in a <p> tag which has margin-bottom set to 0.3em or so. Could that be avoided somehow?

But there are no real stoppers here, seeing that the use of side portlets seems to be appropriate here. Thank you!

Henning

review: Approve (ui*)

[Curtis Hovey (sinzui)]

I agree with Henning.

review: Approve (ui)

[Brad Crittenden (bac)]

Thanks for the UI review Henning and Curtis.

I hadn't noticed the extra space at the bottom of the top portlet. I defeated it with a style="margin-bottom: 0;" and it looks nicer.

For consistency with the other code branchlisting pages I prefer to keep the "Define branch visibility" link in a second portlet.

[lp:~bac/launchpad/bug-652149]

11703. By Brad Crittenden on 2010-10-22

Fixed portlet spacing

11704. By Brad Crittenden on 2010-10-22

Merge from devel. Encountered conflicts with branchlisting files.

11705. By Brad Crittenden on 2010-10-23

Merged new tests from devel

=== modified file 'lib/lp/code/browser/branchlisting.py'
--- lib/lp/code/browser/branchlisting.py	2010-10-20 16:04:58 +0000
+++ lib/lp/code/browser/branchlisting.py	2010-10-23 04:44:50 +0000
@@ -94,6 +94,7 @@
     PersonActiveReviewsView,
     PersonProductActiveReviewsView,
     )
+from lp.code.browser.branchvisibilitypolicy import BranchVisibilityPolicyMixin
 from lp.code.browser.summary import BranchCountSummaryView
 from lp.code.enums import (
     BranchLifecycleStatus,
@@ -532,7 +533,8 @@
             return "listing sortable"
 
 
-class BranchListingView(LaunchpadFormView, FeedsMixin):
+class BranchListingView(LaunchpadFormView, FeedsMixin,
+                        BranchVisibilityPolicyMixin):
     """A base class for views of branch listings."""
     schema = IBranchListingFilter
     field_names = ['lifecycle', 'sort_by']

=== modified file 'lib/lp/code/browser/branchvisibilitypolicy.py'
--- lib/lp/code/browser/branchvisibilitypolicy.py	2010-08-31 11:11:09 +0000
+++ lib/lp/code/browser/branchvisibilitypolicy.py	2010-10-23 04:44:50 +0000
@@ -8,6 +8,7 @@
 __all__ = [
     'AddBranchVisibilityTeamPolicyView',
     'RemoveBranchVisibilityTeamPolicyView',
+    'BranchVisibilityPolicyMixin',
     'BranchVisibilityPolicyView',
     ]
 
@@ -38,6 +39,8 @@
     BranchVisibilityRule,
     TeamBranchVisibilityRule,
     )
+from lp.code.interfaces.branchnamespace import IBranchNamespacePolicy
+from lp.code.interfaces.branchtarget import IBranchTarget
 from lp.code.interfaces.branchvisibilitypolicy import (
     IBranchVisibilityTeamPolicy,
     )
@@ -155,7 +158,24 @@
             self.context.removeTeamFromBranchVisibilityPolicy(item.team)
 
 
-class BranchVisibilityPolicyView(LaunchpadView):
+class BranchVisibilityPolicyMixin:
+    """Mixin class providing visibility rules."""
+    @property
+    def base_visibility_rule(self):
+        return self.context.getBaseBranchVisibilityRule()
+
+    @property
+    def team_policies(self):
+        """The policy items that have a valid team."""
+        return [item for item in self.items if item.team is not None]
+
+    @cachedproperty
+    def items(self):
+        return self.context.getBranchVisibilityTeamPolicies()
+
+
+class BranchVisibilityPolicyView(LaunchpadView,
+                                 BranchVisibilityPolicyMixin):
     """Simple view for displaying branch visibility policies."""
 
     @property
@@ -163,14 +183,6 @@
         name = self.context.displayname
         return 'Set branch visibility policy for %s' % name
 
-    @cachedproperty
-    def items(self):
-        return self.context.getBranchVisibilityTeamPolicies()
-
-    @property
-    def base_visibility_rule(self):
-        return self.context.getBaseBranchVisibilityRule()
-
     @property
     def can_remove_items(self):
         """You cannot remove items if using inherited policy or
@@ -178,8 +190,3 @@
         """
         return (len(self.items) > 0 and
                 not self.context.isUsingInheritedBranchVisibilityPolicy())
-
-    @property
-    def team_policies(self):
-        """The policy items that have a valid team."""
-        return [item for item in self.items if item.team is not None]

=== modified file 'lib/lp/code/browser/tests/test_branchlisting.py'
--- lib/lp/code/browser/tests/test_branchlisting.py	2010-10-20 13:53:15 +0000
+++ lib/lp/code/browser/tests/test_branchlisting.py	2010-10-23 04:44:50 +0000
@@ -33,11 +33,15 @@
     GroupedDistributionSourcePackageBranchesView,
     SourcePackageBranchesView,
     )
+from lp.code.enums import BranchVisibilityRule
 from lp.code.interfaces.seriessourcepackagebranch import (
     IMakeOfficialBranchLinks,
     )
 from lp.code.model.branch import Branch
-from lp.registry.interfaces.person import PersonVisibility
+from lp.registry.interfaces.person import (
+    IPersonSet,
+    PersonVisibility,
+    )
 from lp.registry.interfaces.pocket import PackagePublishingPocket
 from lp.registry.model.person import Owner
 from lp.registry.model.product import Product
@@ -51,6 +55,10 @@
     time_counter,
     )
 from lp.testing.factory import remove_security_proxy_and_shout_at_engineer
+from lp.testing.sampledata import (
+    ADMIN_EMAIL,
+    COMMERCIAL_ADMIN_EMAIL,
+    )
 from lp.testing.views import create_initialized_view
 
 
@@ -422,35 +430,91 @@
         self.assertIs(None, branches)
 
 
-class TestProjectBranchListing(TestCaseWithFactory):
+class TestProjectGroupBranches(TestCaseWithFactory):
+    """Test for the project group branches page."""
 
     layer = DatabaseFunctionalLayer
 
     def setUp(self):
-        super(TestProjectBranchListing, self).setUp()
+        TestCaseWithFactory.setUp(self)
         self.project = self.factory.makeProject()
-        self.product = self.factory.makeProduct(project=self.project)
+
+    def test_project_with_no_branch_visibility_rule(self):
+        view = create_initialized_view(
+            self.project, name="+branches", rootsite='code')
+        privacy_portlet = find_tag_by_id(view(), 'privacy')
+        text = extract_text(privacy_portlet)
+        expected = """
+            Inherited branch visibility for all projects in .* is Public.
+            """
+        self.assertTextMatchesExpressionIgnoreWhitespace(
+            expected, text)
+
+    def test_project_with_private_branch_visibility_rule(self):
+        self.project.setBranchVisibilityTeamPolicy(
+            None, BranchVisibilityRule.FORBIDDEN)
+        view = create_initialized_view(
+            self.project, name="+branches", rootsite='code')
+        privacy_portlet = find_tag_by_id(view(), 'privacy')
+        text = extract_text(privacy_portlet)
+        expected = """
+            Inherited branch visibility for all projects in .* is Forbidden.
+            """
+        self.assertTextMatchesExpressionIgnoreWhitespace(
+            expected, text)
+
+    def _testBranchVisibilityLink(self, user):
+        login_person(user)
+        view = create_initialized_view(
+            self.project, name="+branches", rootsite='code',
+            principal=user)
+        action_portlet = find_tag_by_id(view(), 'action-portlet')
+        text = extract_text(action_portlet)
+        expected = '.*Define branch visibility.*'
+        self.assertTextMatchesExpressionIgnoreWhitespace(
+            expected, text)
+
+    def test_branch_visibility_link_admin(self):
+        # An admin will be displayed a link to define branch visibility in the
+        # action portlet.
+        admin = getUtility(IPersonSet).getByEmail(ADMIN_EMAIL)
+        self._testBranchVisibilityLink(admin)
+
+    def test_branch_visibility_link_commercial_admin(self):
+        # A commercial admin will be displayed a link to define branch
+        # visibility in the action portlet.
+        admin = getUtility(IPersonSet).getByEmail(COMMERCIAL_ADMIN_EMAIL)
+        self._testBranchVisibilityLink(admin)
+
+    def test_branch_visibility_link_non_admin(self):
+        # A non-admin will not see the action portlet.
+        view = create_initialized_view(
+            self.project, name="+branches", rootsite='code')
+        action_portlet = find_tag_by_id(view(), 'action-portlet')
+        self.assertIs(None, action_portlet)
 
     def test_no_branches_gets_message_not_listing(self):
         # If there are no product branches on the project's products, then
         # the view shows the no code hosting message instead of a listing.
-        browser = self.getUserBrowser(
-            canonical_url(self.project, rootsite='code'))
+        self.factory.makeProduct(project=self.project)
+        view = create_initialized_view(
+            self.project, name='+branches', rootsite='code')
         displayname = self.project.displayname
         expected_text = normalize_whitespace(
-                            ("Launchpad does not know where any of %s's "
-                             "projects host their code." % displayname))
-        no_branch_div = find_tag_by_id(browser.contents, "no-branchtable")
+            ("Launchpad does not know where any of %s's "
+             "projects host their code." % displayname))
+        no_branch_div = find_tag_by_id(view(), "no-branchtable")
         text = normalize_whitespace(extract_text(no_branch_div))
         self.assertEqual(expected_text, text)
 
     def test_branches_get_listing(self):
         # If a product has a branch, then the project view has a branch
         # listing.
-        branch = self.factory.makeProductBranch(product=self.product)
-        browser = self.getUserBrowser(
-            canonical_url(self.project, rootsite='code'))
-        table = find_tag_by_id(browser.contents, "branchtable")
+        product = self.factory.makeProduct(project=self.project)
+        self.factory.makeProductBranch(product=product)
+        view = create_initialized_view(
+            self.project, name='+branches', rootsite='code')
+        table = find_tag_by_id(view(), "branchtable")
         self.assertIsNot(None, table)
 
 

=== modified file 'lib/lp/code/stories/branches/xx-branch-visibility-policy.txt'
--- lib/lp/code/stories/branches/xx-branch-visibility-policy.txt	2009-07-20 18:22:54 +0000
+++ lib/lp/code/stories/branches/xx-branch-visibility-policy.txt	2010-10-23 04:44:50 +0000
@@ -1,7 +1,8 @@
-= Branch Visibility Policy Pages =
+Branch Visibility Policy Pages
+==============================
 
 Controlling the branch visibility policies for products and projects is only
-available to launchpad admins and launchpad commercial admins.
+available to Launchpad admins and Launchpad commercial admins.
 
 Not to anonymous people.
 
@@ -64,12 +65,36 @@
     >>> print commercial_browser.url
     http://launchpad.dev/firefox/+branchvisibility
 
-    >>> commercial_browser.getLink('Customise policy for Mozilla Firefox').click()
+    >>> commercial_browser.getLink(
+    ...     'Customise policy for Mozilla Firefox').click()
     >>> print commercial_browser.url
     http://launchpad.dev/firefox/+addbranchvisibilitypolicy
 
-
-== Default policies ==
+Admins can define branch visibility on projects, too.
+
+    >>> admin_browser.open('http://code.launchpad.dev/mozilla')
+    >>> admin_browser.getLink('Define branch visibility').click()
+    >>> print admin_browser.url
+    http://launchpad.dev/mozilla/+branchvisibility
+
+    >>> admin_browser.getLink('Set policy for a team').click()
+    >>> print admin_browser.url
+    http://launchpad.dev/mozilla/+addbranchvisibilitypolicy
+
+As can commercial admins.
+
+    >>> commercial_browser.open('http://code.launchpad.dev/mozilla')
+    >>> commercial_browser.getLink('Define branch visibility').click()
+    >>> print commercial_browser.url
+    http://launchpad.dev/mozilla/+branchvisibility
+
+    >>> commercial_browser.getLink('Set policy for a team').click()
+    >>> print commercial_browser.url
+    http://launchpad.dev/mozilla/+addbranchvisibilitypolicy
+
+
+Default policies
+----------------
 
 The default policies are to have all branches public.  When the branch policy
 objects are created for products they are constructed with the branch policy
@@ -79,10 +104,12 @@
 
     >>> admin_browser.open('http://launchpad.dev/firefox/+branchvisibility')
 
-    >>> print extract_text(find_tag_by_id(admin_browser.contents, 'inherited'))
+    >>> print extract_text(
+    ...     find_tag_by_id(admin_browser.contents, 'inherited'))
     Using inherited policy from the Mozilla Project.
 
-    >>> print extract_text(find_tag_by_id(admin_browser.contents, 'default-policy'))
+    >>> print extract_text(
+    ...     find_tag_by_id(admin_browser.contents, 'default-policy'))
     Default branch visibility for all branches in Mozilla Firefox is Public.
 
 When the project is using the inherited policy, the user can either
@@ -100,8 +127,11 @@
     >>> admin_browser.getLink('Edit inherited policy').click()
     >>> print find_tag_by_id(admin_browser.contents, 'inherited')
     None
-    >>> print extract_text(find_tag_by_id(admin_browser.contents, 'default-policy'))
-    Default branch visibility for all branches in the Mozilla Project is Public.
+    >>> print extract_text(
+    ...     find_tag_by_id(admin_browser.contents, 'default-policy'))
+    Default branch visibility for all branches
+    in the Mozilla Project is Public.
+
     >>> actions = find_tag_by_id(admin_browser.contents, 'policy-actions')
     >>> for anchor in actions.fetch('a'):
     ...     print '%s -> %s' % (anchor.renderContents(), anchor['href'])
@@ -109,11 +139,13 @@
 
 Products that don't have an associated project look similar to projects.
 
-    >>> admin_browser.open('http://launchpad.dev/alsa-utils/+branchvisibility')
+    >>> admin_browser.open(
+    ...     'http://launchpad.dev/alsa-utils/+branchvisibility')
 
     >>> print find_tag_by_id(admin_browser.contents, 'inherited')
     None
-    >>> print extract_text(find_tag_by_id(admin_browser.contents, 'default-policy'))
+    >>> print extract_text(
+    ...     find_tag_by_id(admin_browser.contents, 'default-policy'))
     Default branch visibility for all branches in alsa-utils is Public.
     >>> actions = find_tag_by_id(admin_browser.contents, 'policy-actions')
     >>> for anchor in actions.fetch('a'):
@@ -121,7 +153,8 @@
     Set policy for a team -> +addbranchvisibilitypolicy
 
 
-== Overriding the inherited policy ==
+Overriding the inherited policy
+-------------------------------
 
 Setting any policy item overrides the use of an inherited policy, even if
 it new policy item just specifies public branches for everyone.
@@ -173,7 +206,8 @@
     Ubuntu Gnome Team: Private
 
 
-== Removing policy items ==
+Removing policy items
+---------------------
 
 When removing the policy items, the defined items are shown as a list
 of checkboxes.  Any number of these can be selected, and when the
@@ -206,7 +240,8 @@
 Before we remove them, let's ensure that the commercial admins can see
 the removal page.
 
-    >>> commercial_browser.open('http://launchpad.dev/firefox/+branchvisibility')
+    >>> commercial_browser.open(
+    ...     'http://launchpad.dev/firefox/+branchvisibility')
     >>> commercial_browser.getLink('Remove policy items').click()
     >>> print commercial_browser.url
     http://launchpad.dev/firefox/+removebranchvisibilitypolicy
@@ -228,7 +263,8 @@
 Firefox will go back to inheriting the polices of Mozilla. Let's let
 the commercial admin do the removal to ensure he has the permission.
 
-    >>> commercial_browser.open('http://launchpad.dev/firefox/+branchvisibility')
+    >>> commercial_browser.open(
+    ...     'http://launchpad.dev/firefox/+branchvisibility')
     >>> commercial_browser.getLink('Remove policy items').click()
     >>> commercial_browser.getControl('Ubuntu Gnome Team: Private').click()
     >>> commercial_browser.getControl('Remove Selected Policy Items').click()

=== modified file 'lib/lp/code/templates/branch-visibility.pt'
--- lib/lp/code/templates/branch-visibility.pt	2009-08-24 02:09:05 +0000
+++ lib/lp/code/templates/branch-visibility.pt	2010-10-23 04:44:50 +0000
@@ -41,7 +41,7 @@
   </div>
 
   <div style="padding-left: 1em" id="policy-actions">
-  <tal:using-inhertied-policy condition="context/isUsingInheritedBranchVisibilityPolicy">
+  <tal:using-inherited-policy condition="context/isUsingInheritedBranchVisibilityPolicy">
       <p>
         <img src="/@@/edit" alt="edit" />
         <a tal:define="inherited_url context/project/fmt:url"
@@ -56,7 +56,7 @@
           </tal:displayname>
         </a>
       </p>
-  </tal:using-inhertied-policy>
+  </tal:using-inherited-policy>
 
   <tal:no-inhertied-policy condition="not: context/isUsingInheritedBranchVisibilityPolicy">
       <p>

=== modified file 'lib/lp/code/templates/project-branches.pt'
--- lib/lp/code/templates/project-branches.pt	2010-10-18 21:32:32 +0000
+++ lib/lp/code/templates/project-branches.pt	2010-10-23 04:44:50 +0000
@@ -3,20 +3,49 @@
   xmlns:tal="http://xml.zope.org/namespaces/tal"
   xmlns:metal="http://xml.zope.org/namespaces/metal"
   xmlns:i18n="http://xml.zope.org/namespaces/i18n"
-  metal:use-macro="view/macro:page/main_only"
+  metal:use-macro="view/macro:page/main_side"
   i18n:domain="launchpad">
 
   <body>
 
+    <metal:side fill-slot="side"
+                tal:define="context_menu context/menu:context"
+                tal:condition="not:
+                context/codehosting_usage/enumvalue:UNKNOWN">
+      <div id="privacy"
+           tal:define="priv not:view/base_visibility_rule/enumvalue:PUBLIC"
+           tal:attributes="class python: priv and 'first portlet private' or 'first portlet public'">
+        <p id="default-policy" style="margin-bottom: 0;">
+          Inherited branch visibility for all projects in
+          <strong tal:content="context/displayname">Project</strong> is
+          <strong tal:content="view/base_visibility_rule/title">Public</strong>.
+        </p>
+
+        <tal:has-policies condition="view/team_policies">
+          <p>Except for the following teams:</p>
+          <ul id="team-policies">
+            <li tal:repeat="item view/team_policies">
+              <tal:team replace="structure item/team/fmt:link:mainsite"
+                        condition="item/team">Team Name</tal:team>:
+              <tal:team condition="not: item/team">Everyone</tal:team>
+              <tal:policy replace="item/rule/title">Public</tal:policy>
+            </li>
+          </ul>
+        </tal:has-policies>
+      </div>
+
+      <div id="action-portlet"
+           class="portlet"
+           tal:define="menu context/menu:overview;
+                       link menu/branch_visibility"
+           tal:condition="link/enabled">
+        <div tal:content="structure link/render" />
+      </div>
+    </metal:side>
+
     <div metal:fill-slot="main"
          tal:define="branches view/branches">
 
-      <div style="float:right" id="floating-links"
-           tal:define="menu context/menu:overview">
-        <div tal:define="link menu/branch_visibility"
-             tal:condition="link/enabled"
-             tal:content="structure link/render" />
-      </div>
       <tal:no-branches
         condition="not:context/has_branches">
         <div id="no-branchtable">
@@ -35,7 +64,7 @@
               <li>
                 <a tal:attributes="href product/@@+code-index/configure_codehosting/fmt:url"
                    tal:content="product/title" />
-              </li>  
+              </li>
             </ul>
         </div>
         </div>

=== modified file 'lib/lp/registry/browser/project.py'
--- lib/lp/registry/browser/project.py	2010-09-23 03:17:10 +0000
+++ lib/lp/registry/browser/project.py	2010-10-23 04:44:50 +0000
@@ -254,7 +254,7 @@
             'RDF</abbr> metadata')
         return Link('+rdf', text, icon='download-icon')
 
-    @enabled_with_permission('launchpad.Admin')
+    @enabled_with_permission('launchpad.Commercial')
     def branch_visibility(self):
         text = 'Define branch visibility'
         return Link('+branchvisibility', text, icon='edit', site='mainsite')

=== modified file 'lib/lp/testing/sampledata.py'
--- lib/lp/testing/sampledata.py	2010-08-30 17:05:49 +0000
+++ lib/lp/testing/sampledata.py	2010-10-23 04:44:50 +0000
@@ -58,7 +58,6 @@
 USER_EMAIL = '[e-mail]'
 VCS_IMPORTS_MEMBER_EMAIL = '[e-mail]'
 COMMERCIAL_ADMIN_EMAIL = '[e-mail]'
-ADMIN_EMAIL = '[e-mail]'
 SAMPLE_PERSON_EMAIL = USER_EMAIL
 # A user that is an admin of ubuntu-team, which has upload rights
 # to Ubuntu.