Merge lp:~bac/launchpad/bug-568659 into lp:launchpad

[Brad Crittenden]

Don't let package portlet set focus.

= Summary =

The product package portlet lives towards the bottom of the product
index page and is currently stealing focus, which causes the page to
scroll needlessly and annoyingly.

== Proposed fix ==

Set 'initial_focus_widget' to None to avoid the scroll.

== Pre-implementation notes ==

None.

== Implementation details ==

As above.

== Tests ==

bin/test -vvt product-portlet-packages-view.txt

== Demo and Q/A ==

Go to a product on launchpad.net that does not have a package and ensure
the page doesn't scroll.

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/lp/registry/browser/product.py
  lib/lp/registry/browser/tests/product-portlet-packages-view.txt

== Pyflakes Doctest notices ==

lib/lp/registry/browser/tests/product-portlet-packages-view.txt
    30: local variable 'ignore' is assigned to but never used

[Eleanor Berger (intellectronica)]

review: Approve

=== modified file 'lib/lp/registry/browser/product.py'
--- lib/lp/registry/browser/product.py	2010-04-24 02:41:03 +0000
+++ lib/lp/registry/browser/product.py	2010-04-27 00:46:27 +0000
@@ -1050,6 +1050,7 @@
     suggestions = None
     max_suggestions = 8
     other_package = object()
+    initial_focus_widget = None
 
     @cachedproperty
     def sourcepackages(self):

=== modified file 'lib/lp/registry/browser/tests/product-portlet-packages-view.txt'
--- lib/lp/registry/browser/tests/product-portlet-packages-view.txt	2010-04-14 17:16:56 +0000
+++ lib/lp/registry/browser/tests/product-portlet-packages-view.txt	2010-04-27 00:46:27 +0000
@@ -49,6 +49,10 @@
     >>> print view.suggestions
     []
 
+The view does not set focus to its form otherwise it will cause the page to scroll.
+    >>> view.focusedElementScript()
+    ''
+
 No distribution source packages match so the user is shown an
 appropriate message asking to suggest a match.