Merge lp:~bac/launchpad/bug-559200 into lp:launchpad
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Aaron Bentley | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | not available | ||||
Proposed branch: | lp:~bac/launchpad/bug-559200 | ||||
Merge into: | lp:launchpad | ||||
Diff against target: |
192 lines (+130/-15) 3 files modified
lib/lp/code/windmill/tests/test_productseries_setbranch.py (+58/-0) lib/lp/registry/browser/productseries.py (+34/-15) lib/lp/registry/browser/tests/productseries-setbranch-view.txt (+38/-0) |
||||
To merge this branch: | bzr merge lp:~bac/launchpad/bug-559200 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Aaron Bentley (community) | Approve | ||
Review via email: mp+23256@code.launchpad.net |
Commit message
Fix form validation errors on productseries/
Description of the change
= Summary =
Field validation was not properly implemented which allowed OOPS to
happen or for errors to go unnoticed. Also a test was missing to prove
the JS controls were properly loaded.
== Proposed fix ==
Fixed the validation by not return a next_url when errors occur. Wrote
new windmill test that simply demonstrates the selective enabling and
disabling of one field, which proves the JS controls are loaded and
working. Full tests for those controls are already done elsewhere.
== Pre-implementation notes ==
Brief chats with Curtis.
== Implementation details ==
As above.
== Tests ==
bin/test -vvm lp.code -t test_productser
bin/test -vvm lp.registry productseries-
== Demo and Q/A ==
Go to http://
branch. Return and try to create another new branch or link to a an
external repository using the same branch name. Verify you get a
validation error.
= Launchpad lint =
Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.
Linting changed files:
lib/lp/
lib/lp/
lib/lp/
== Pylint notices ==
All of these look to be bogus except the line too long, which I will fix.
lib/lp/
34: [F0401] Unable to import 'zope.component'
35: [F0401] Unable to import 'zope.app.
36: [F0401] Unable to import 'zope.formlib'
38: [F0401] Unable to import 'zope.schema'
39: [F0401] Unable to import 'zope.schema.
41: [F0401] Unable to import 'z3c.ptcompat'
43: [F0401] Unable to import 'canonical.
44: [F0401] Unable to import 'canonical.
45: [F0401] Unable to import 'canonical.
46: [F0401] Unable to import 'lp.blueprints.
48: [F0401] Unable to import 'lp.blueprints.
50: [F0401] Unable to import 'lp.bugs.
51: [F0401] Unable to import 'lp.bugs.
52: [F0401] Unable to import 'canonical.
53: [F0401] Unable to import 'lp.code.
54: [F0401] Unable to import 'lp.code.
55: [F0401] Unable to import 'lp.code.enums'
56: [F0401] Unable to import 'lp.code.
58: [F0401] Unable to import 'lp.code.
59: [F0401] Unable to import 'lp.code.
60: [F0401] Unable to import 'lp.code.
62: [F0401] Unable to import 'lp.services.
63: [F0401] Unable to import 'lp.bugs.
64: [F0401] Unable to import 'canonical.
65: [F0401] Unable to import 'lp.registry.
66: [F0401] Unable to import
'lp.registry.
69: [F0401] Unable to import 'lp.registry.
71: [F0401] Unable to import 'lp.translation
72: [F0401] Unable to import
'lp.translation
74: [F0401] Unable to import 'lp.services.
75: [F0401] Unable to import 'canonical.
79: [F0401] Unable to import 'canonical.
80: [F0401] Unable to import 'canonical.
81: [F0401] Unable to import 'canonical.
83: [F0401] Unable to import 'canonical.
85: [F0401] Unable to import 'canonical.
86: [F0401] Unable to import 'canonical.
87: [F0401] Unable to import 'canonical.
89: [F0401] Unable to import 'lp.registry.
91: [F0401] Unable to import 'lp.registry.
92: [F0401] Unable to import 'lp.registry.
94: [F0401] Unable to import 'lazr.enum'
95: [F0401] Unable to import 'lazr.restful.
383: [E1002, ProductSeriesUb
an old style class
403: [E1002, ProductSeriesUb
on an old style class
424: [E1002, ProductSeriesUb
super on an old style class
753: [E1002, ProductSeriesSe
an old style class
870: [E1002, ProductSeriesSe
on an old style class
870: [E1002, ProductSeriesSe
on an old style class
lib/lp/
35: [C0301] Line too long (79/78)
11: [F0401] Unable to import 'canonical.
13: [F0401] Unable to import 'lp.code.
14: [F0401] Unable to import 'lp.testing'