Merge lp:~bac/launchpad/bug-436978-pg-index into lp:launchpad

[Brad Crittenden]

Remove project series and milestone information from project group index page.

[Brad Crittenden (bac)]

= Summary =

Bug 436978 reports that project group index pages time out.

== Proposed fix ==

The main reason for the time out is collecting information about milestones for
projects that have a lot of them.

Upon review of that page we determined that including series and milestone
information about all projects in a project group does not make sense. That
information is too detailed for that level view.

== Pre-implementation notes ==

Call with Curtis.

== Implementation details ==

Simply remove the series and milestone data from the page template. The list was
then converted from a <dl> to a <ul>.

The menus at the bottom of that section were placed horizontally which caused ugly
wrapping. They have been changed to be vertical and look much better.

== Tests ==

bin/test -vvt xx-project-index.txt

== Demo and Q/A ==

http://launchpad.dev/mozilla
https://edge.launchpad.net/gnome

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/lp/registry/stories/project/xx-project-index.txt
  lib/lp/registry/templates/project-index.pt

[Brad Crittenden (bac)]

Screenshots:

http://people.canonical.com/~bac/project-group-index-old.png
http://people.canonical.com/~bac/project-group-index-new.png

[Martin Albisetti (beuno)]

Add some vertical spacing between the list of projects and "(+) Register a proj..." and ui=me!

review: Approve (ui)

[Brad Crittenden (bac)]

> Add some vertical spacing between the list of projects and "(+) Register a
> proj..." and ui=me!

Added 0.5em and it looks better. Thanks for the review.

[Edwin Grubbs (edwin-grubbs)]

Looks good.

merge-approved

-Edwin

review: Approve (code)

=== modified file 'lib/lp/registry/stories/project/xx-project-index.txt'
--- lib/lp/registry/stories/project/xx-project-index.txt	2009-09-18 15:24:30 +0000
+++ lib/lp/registry/stories/project/xx-project-index.txt	2009-10-14 18:50:26 +0000
@@ -30,25 +30,16 @@
     Projects
     Gnome Applets ...
     Evolution ...
-    trunk series: 2.1.6,
     GNOME Terminal ...
     gnomebaker ...
-    trunk series: 2.1.7, 2.1.7
     NetApplet ...
-    trunk series: 1.0,
     ...
 
-And the projects, milestone, and releases are linked.
+The projects are linked.
 
     >>> print anon_browser.getLink('gnomebaker').url
     http://launchpad.dev/gnomebaker
 
-    >>> print anon_browser.getLink('1.0').url
-    http://launchpad.dev/netapplet/trunk/1.0
-
-    >>> print anon_browser.getLink('2.1.7').url
-    http://launchpad.dev/gnomebaker/trunk/2.1.7
-
 The project overview page contains a link to register new products with the
 project. It is only available to users which have 'Admin' privileges on the
 project.

=== modified file 'lib/lp/registry/templates/project-index.pt'
--- lib/lp/registry/templates/project-index.pt	2009-09-22 17:39:22 +0000
+++ lib/lp/registry/templates/project-index.pt	2009-10-14 18:50:26 +0000
@@ -101,29 +101,11 @@
             There are no projects registered for
             <span tal:replace="context/displayname">project displayname</span>.
           </p>
-          <dl tal:condition="context/products"
+          <ul tal:condition="context/products"
               tal:repeat="product context/products">
-            <dt><a tal:replace="structure product/fmt:link">product</a></dt>
-            <dd tal:define="dev_focus product/development_focus">
-              <a tal:attributes="href dev_focus/fmt:url"
-                 tal:content="dev_focus/name">trunk</a>
-              series:
-              <tal:releases repeat="release dev_focus/releases">
-                <strong>
-                  <a tal:attributes="href release/fmt:url"
-                     tal:content="release/version">release
-                </a></strong>,
-              </tal:releases>
-              <tal:releases repeat="milestone dev_focus/milestones">
-                <strong>
-                  <a tal:attributes="href milestone/fmt:url"
-                     tal:content="milestone/name">milestone
-                  </a></strong><tal:comma
-                    condition="not:repeat/milestone/end">,</tal:comma>
-              </tal:releases>
-            </dd>
-          </dl>
-          <ul class="horizontal">
+            <li><a tal:replace="structure product/fmt:link">product</a></li>
+          </ul>
+          <ul style="margin-top: 0.5em;">
             <li tal:condition="context/menu:overview/new_product/enabled">
               <a tal:replace="structure context/menu:overview/new_product/fmt:link" />
             </li>
@@ -158,4 +140,3 @@
 
   </body>
 </html>
-