Merge lp:~bac/launchpad/bug-436508-ssh into lp:launchpad

Proposed by Brad Crittenden
Status: Merged
Approved by: Edwin Grubbs
Approved revision: no longer in the source branch.
Merged at revision: not available
Proposed branch: lp:~bac/launchpad/bug-436508-ssh
Merge into: lp:launchpad
Diff against target: 59 lines
3 files modified
lib/lp/registry/browser/person.py (+1/-1)
lib/lp/registry/stories/foaf/xx-add-sshkey.txt (+4/-4)
lib/lp/registry/templates/person-portlet-contact-details.pt (+1/-1)
To merge this branch: bzr merge lp:~bac/launchpad/bug-436508-ssh
Reviewer Review Type Date Requested Status
Edwin Grubbs (community) code Approve
Review via email: mp+13847@code.launchpad.net

Commit message

Correct 'SSH keys' capitalization.

To post a comment you must log in.
Revision history for this message
Brad Crittenden (bac) wrote :

= Summary =

Trivial fix for bug 436508 to correct the capitalization.

== Proposed fix ==

'SSH Keys' -> 'SSH keys'

== Pre-implementation notes ==

None

== Implementation details ==

N/A

== Tests ==

bin/test -vvt xx-add-sshkey.txt

== Demo and Q/A ==

Go to https://launchpad.dev/~mark and verify the text is correct.

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/lp/registry/stories/foaf/xx-add-sshkey.txt
  lib/lp/registry/templates/person-portlet-contact-details.pt
  lib/lp/registry/browser/person.py

== Pylint notices ==

lib/lp/registry/browser/person.py
    117: [F0401] Unable to import 'lazr.delegates' (No module named delegates)
    118: [F0401] Unable to import 'lazr.config' (No module named config)
    119: [F0401] Unable to import 'lazr.restful.interface' (No module named restful)

Revision history for this message
Edwin Grubbs (edwin-grubbs) wrote :

Looks good.

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/lp/registry/browser/person.py'
2--- lib/lp/registry/browser/person.py 2009-10-19 22:49:43 +0000
3+++ lib/lp/registry/browser/person.py 2009-10-26 18:25:20 +0000
4@@ -1071,7 +1071,7 @@
5 @enabled_with_permission('launchpad.Special')
6 def sshkeys(self):
7 target = '+editsshkeys'
8- text = 'SSH Keys'
9+ text = 'SSH keys'
10 return Link(target, text)
11
12 def gpgkeys(self):
13
14=== modified file 'lib/lp/registry/stories/foaf/xx-add-sshkey.txt'
15--- lib/lp/registry/stories/foaf/xx-add-sshkey.txt 2009-09-18 15:24:30 +0000
16+++ lib/lp/registry/stories/foaf/xx-add-sshkey.txt 2009-10-26 18:25:20 +0000
17@@ -15,9 +15,9 @@
18 Sample Person in Launchpad
19 >>> print extract_text(
20 ... find_tag_by_id(anon_browser.contents, 'sshkeys'))
21- SSH Keys: andrew@trogdor
22+ SSH keys: andrew@trogdor
23
24-Salgado does not have a key, so we omit the 'SSH Keys' section for anonymous
25+Salgado does not have a key, so we omit the 'SSH keys' section for anonymous
26 users.
27
28 >>> anon_browser.open('http://launchpad.dev/~salgado')
29@@ -35,7 +35,7 @@
30 Guilherme Salgado in Launchpad
31 >>> print extract_text(
32 ... find_tag_by_id(browser.contents, 'sshkeys'))
33- SSH Keys: Add an SSH key
34+ SSH keys: Add an SSH key
35 No SSH keys registered.
36
37
38@@ -110,7 +110,7 @@
39 Guilherme Salgado in Launchpad
40 >>> print extract_text(
41 ... find_tag_by_id(browser.contents, 'sshkeys'))
42- SSH Keys: Update SSH keys
43+ SSH keys: Update SSH keys
44 salgado@canario
45 salgado@canario
46 >>> browser.getLink('Update SSH keys').click()
47
48=== modified file 'lib/lp/registry/templates/person-portlet-contact-details.pt'
49--- lib/lp/registry/templates/person-portlet-contact-details.pt 2009-09-16 17:56:17 +0000
50+++ lib/lp/registry/templates/person-portlet-contact-details.pt 2009-10-26 18:25:20 +0000
51@@ -155,7 +155,7 @@
52 </dl>
53
54 <dl id="sshkeys" tal:condition="view/should_show_sshkeys_section">
55- <dt>SSH Keys:
56+ <dt>SSH keys:
57 <a tal:replace="structure overview_menu/editsshkeys/fmt:icon" />
58 </dt>
59 <dd tal:define="sshkeys context/sshkeys">