Merge lp:~bac/launchpad/bug-430748-team-mailinglist into lp:launchpad
Proposed by
Brad Crittenden
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Edwin Grubbs | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | not available | ||||
Proposed branch: | lp:~bac/launchpad/bug-430748-team-mailinglist | ||||
Merge into: | lp:launchpad | ||||
Diff against target: | None lines | ||||
To merge this branch: | bzr merge lp:~bac/launchpad/bug-430748-team-mailinglist | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Edwin Grubbs (community) | code | Approve | |
Review via email:
|
To post a comment you must log in.
= Summary =
Fix bug 430784 - convert team-mailinglist.pt to UI 3.0.
== Proposed fix ==
JFDI
== Pre-implementation notes ==
n/a
== Implementation details ==
Simple fix to the template and fix the tests.
== Tests ==
bin/test -vvm lp.registry
== Demo and Q/A ==
The template and view are multi-modal. The same page is used to apply for a mailing
list and configure an existing one.
All of these views are available as screenshots at: people. canonical. com/~bac/ bug-430748- team-mailinglis t/
http://
* Run 'make run_all' /launchpad. dev/~ubuntu- team /launchpad. dev/+mailinglis ts and approve the list /launchpad. dev/~ubuntu- team and click on 'Configure mailing list'
* As mark, go to https:/
* Click on 'Create a mailing list'
* Apply
* Go to https:/
* Return to https:/
* You'll now see one of the other views where the admin can set the welcome message.
* Another view is for a rejected team. Apply, reject, look.
= Launchpad lint =
Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.
Linting changed files: registry/ templates/ team-mailinglis t.pt registry/ stories/ mailinglists/ lifecycle. txt registry/ stories/ mailinglists/ admin-approval. txt
lib/lp/
lib/lp/
lib/lp/