Merge lp:~bac/launchpad/bug-421976-pgp-ssh-wiki into lp:launchpad
Proposed by
Brad Crittenden
Status: | Merged | ||||
---|---|---|---|---|---|
Merged at revision: | not available | ||||
Proposed branch: | lp:~bac/launchpad/bug-421976-pgp-ssh-wiki | ||||
Merge into: | lp:launchpad | ||||
Diff against target: | None lines | ||||
To merge this branch: | bzr merge lp:~bac/launchpad/bug-421976-pgp-ssh-wiki | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Curtis Hovey (community) | code, ui | Approve | |
Canonical Launchpad Engineering | Pending | ||
Review via email:
|
To post a comment you must log in.
= Summary =
Bug 421976 addresses the need to update three page templates: editpgpkeys. pt editsshkeys. pt editwikinames. pt
person-
person-
person-
== Proposed fix ==
The changes made were mostly mechanical. Details are below in the QA section.
== Pre-implementation notes ==
N/A
== Tests ==
bin/test -vvm lp.registry -t gpg -t wiki -t ssh
== Demo and Q/A ==
Screenshots, old and new, are people. canonical. com/~bac/ bug-421976- pgp-ssh- wiki/
at:http://
Login as Salgado for these demos.
Each of these page templates is a mush of hand-built forms rendered
using a LaunchpadView. At some point these pages should be converted
to LaunchpadFormView but for expediency I am not now.
For all pages:
* added label and page_title to the views and removed from pagetitles.py.
* faked LaunchpadFormView by putting the view/label into an <h1> at
the top of the page.
* Added a 'cancel_url' property and manually use it in the template.
The cancel url is set to '+edit' for all, though perhaps just
returning to the user's page would be best. It depends on what the
+edit page ends up looking.
* Several of these pages use the Launchpad help system. Is the pop-up
help system being removed? The conversion primer indicates that is
the case that decision needs to be vetted.
* https:/ /launchpad. dev/~salgado/ +editwikinames
* No changes beyond the above.
* https:/ /launchpad. dev/~salgado/ +editsshkeys
* Discovered the textarea has always been absurdly small due to
using 'height' and 'width' rather than the correct 'rows' and
'cols'. Now it renders as a usable size.
* This form should use a file chooser that gets uploaded rather than
a text widget that the user must paste into.
* https:/ /launchpad. dev/~salgado/ +editpgpkeys
* No changes beyond the above.
= Launchpad lint =
Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.
Linting changed files: /launchpad/ pagetitles. py registry/ browser/ person. py registry/ stories/ foaf/xx- add-sshkey. txt registry/ stories/ gpg-coc/ 01-claimgpg. txt registry/ templates/ person- editpgpkeys. pt registry/ templates/ person- editsshkeys. pt registry/ templates/ person- editwikinames. pt
lib/canonical
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
== Pylint notices ==
lib/lp/ registry/ browser/ person. py interface' (No module named restful)
118: [F0401] Unable to import 'lazr.delegates' (No module named delegates)
119: [F0401] Unable to import 'lazr.config' (No module named config)
120: [F0401] Unable to import 'lazr.restful.