lp:~bac/juju-gui/trunkcopy

Created by Brad Crittenden on 2012-12-18 and last modified on 2012-12-18
Get this branch:
bzr branch lp:~bac/juju-gui/trunkcopy
Only Brad Crittenden can upload to this branch. If you are Brad Crittenden please log in for upload directions.

Branch merges

Related bugs

Related blueprints

Branch information

Owner:
Brad Crittenden
Project:
juju-gui
Status:
Development

Recent revisions

285. By Benji York on 2012-12-17

Make the prod tests pass.

Changes a test that was failing because of some slight style difference to be
more direct. Some slight style differences still exist between prod and dev.

The charm model module (app/models/charm.js) is now included in the combined
and minified JS file.

The event-simulate and node-event-simulate functions are needed for the tests,
so they are now directly loaded by test/index.html.

The test_charm_configuration.js file needs juju-charm-models but that module
was not specified.

test/test_model.js had to be rearranged so the YUI().use method was called
inside the "before" method instead of around the entire test module. This
resulted in a mass reindenting.

Incidentally: Fixes the Makefile so YUI module assets are in the right place
so requests for them do not 404.

R=gary.poster, teknico
CC=
https://codereview.appspot.com/6947057

284. By Gary Poster on 2012-12-14

Fix charm deployment

Fix build regression that kept GUI from connecting to remote web socket. No tests because this is a build artifact; we should have tests for them but do not have infrastructure for this.

R=bac, benji
CC=
https://codereview.appspot.com/6948055

283. By Madison Scott-Clary on 2012-12-14

make clean to remove links

The clean target now removes symlinks in app/assets/javascripts.

R=gary.poster, bac
CC=
https://codereview.appspot.com/6945057

282. By Francesco Banconi on 2012-12-14

Fix GUI breakage on browser resizing.

Fixed how yui events are handled by the component framework.
Also added two tests:
- ensure that the module synthetic events binding works;
- ensure that the custom events 'beforePageSizeRecalculation'
  and 'afterPageSizeRecalculation' are correctly fired by
  the environment view when the browser is resized.

QA: resize the browser, open the charm panel, resize the
    browser again, close the charm panel, resize again,
    re-open the panel...

R=benjamin.saller, gary.poster
CC=
https://codereview.appspot.com/6941053

281. By Nicola Larosa on 2012-12-14

Misc. improvements to Makefile.

Eliminate debug/prod link duplication, avoid unnecessary rebuilds, add version info to build.

R=gary.poster, frankban
CC=
https://codereview.appspot.com/6936045

280. By Madison Scott-Clary on 2012-12-13

Allow running targets without using bzr

Added the flag NO_BZR which lets you run make as `NO_BZR=1 make [target]` in order to prevent make from running bzr commands, which can be slow due to network access, providing sensible defaults instead.

R=gary.poster, benjamin.saller
CC=
https://codereview.appspot.com/6873071

279. By Francesco Banconi on 2012-12-13

Restored notifications tests.

This branch restores the tests previously skipped
(as a consequence of the topology refactor) in
``test_application_notifications``.

Simplified the way the number of notifications is
tested: now, rather than checking a value in the DOM,
we check how many model instances are present in
the notifications model list.

Also added a test for the notifications view, that was
no longer exercised due to the change described above.

R=gary.poster, benjamin.saller
CC=
https://codereview.appspot.com/6942045

278. By Nicola Larosa on 2012-12-12

Three doc fixes that were left behind.

Trivial, self-reviewed.

R=
CC=
https://codereview.appspot.com/6922053

277. By Francesco Banconi on 2012-12-12

Fix production server.

...and I hope uistaging as a consequence.
The topology views were not correctly
referenced in modules.js.

R=
CC=
https://codereview.appspot.com/6927053

276. By Nicola Larosa on 2012-12-12

Put deploy docs in README, add HACKING.

Move the development instructions from the README file to a newly created HACKING one, update them, link the HACKING into the docs. Put deploying instructions in the README file. Revise all docs updating them, and fixing markup and links.

R=frankban, gary.poster
CC=
https://codereview.appspot.com/6924047

Branch metadata

Branch format:
Branch format 7
Repository format:
Bazaar repository format 2a (needs bzr 1.16 or later)
Stacked on:
lp:juju-gui/experimental
This branch contains Public information 
Everyone can see this information.

Subscribers