lp:~bac/juju-gui/trunk

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:juju-gui/experimental

Juju GUI Hackers: Pending requested 2012-11-06

Diff: 13 lines (+2/-1)

1 file modified

Makefile (+2/-1)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

225. By Brad Crittenden on 2012-11-06

Fix error in makefile where sprites could not be generated after the first time

224. By Brad Crittenden on 2012-11-05

Use two radius button borders.

* Further enhancement of CSS defined buttons.

* Expanded the README to explicitly state where the server can be
  accessed when run locally. This was in response to a confused user
  in IRC.

223. By Brad Crittenden on 2012-11-02

CSS styling for buttons

* Apply CSS styling to buttons to get them closer to the visual design
  assets.

* Add a top-level rule to specify font-family which is needed to
  override the bootstrap setting rule.

* Drive-by: remove redundant 'font-family' rules.

* Drive-by: fix lint-yuidoc.

R=thiago, gary.poster
CC=
https://codereview.appspot.com/6811062

222. By Nicola Larosa on 2012-11-01

Add the README to the docs.

Add the README to the docs by symlinking it from the docs directory,
integrating it into the docs index, and adjusting it to better fit
with the rest.

R=bac, gary.poster
CC=
https://codereview.appspot.com/6820071

221. By Gary Poster on 2012-11-01

Convert charm popup to full side display panel

This makes relatively small changes to adjust the existing charm store panels to be displayed down the full right side, per design specs. It does not touch the display of the panels themselves, other than to adjust the scrolling.

Per reviews, some name normalization occurred as well (e.g., "panel" became "popup" in various names).

R=thiago.veronezi, bac
CC=
https://codereview.appspot.com/6775058

220. By Gary Poster on 2012-11-01

Change charm search to use HTML5 placeholder

CSS does not allow you to specify a selector for a dynamic empty (or not empty) field value. The two approaches around it I found are JS and required/:valid. I chose required/:valid because it required no JS and seemed simpler. However, this required a CSS workaround: bootstrap wants to highlight focused invalid fields with a red glow. I changed this to have the usual blue glow in the case of this one field.

R=bac, benjamin.saller
CC=
https://codereview.appspot.com/6816046

219. By Gary Poster on 2012-11-01

Add more review docs

Docs for starting a branch, preparing a branch for review, and reviewing.

Revised with better ReST format.

Self-approved.

218. By Gary Poster on 2012-11-01

Add more review docs

Docs for starting a branch, preparing a branch for review, and reviewing.

Self-approved.

217. By Gary Poster on 2012-10-31

'make server' should not always run yuidoc

I discovered that 'make server' always ran yuidoc. This was because, in part, the automatically generated FILES list included inappropriate files. There is another factor that affects this that I did not identify, but fixing the first problem is sufficient.

Fixing the problem specified the JS files more tightly, which revealed a few more lint changes.

I did a fly-by in the README.

R=
CC=
https://codereview.appspot.com/6823057

216. By Thiago Veronezi on 2012-10-31

Automatic sprite image generation

The Makefile will automatically generate the sprite png and css
files during the "make server" call for all the images under the
"app/assets/images" folder.

R=gary.poster
CC=
https://codereview.appspot.com/6811050