Merge lp:~bac/juju-gui/send-bundle-id-to-deployer into lp:juju-gui/experimental
Status: | Merged |
---|---|
Merged at revision: | 1202 |
Proposed branch: | lp:~bac/juju-gui/send-bundle-id-to-deployer |
Merge into: | lp:juju-gui/experimental |
Diff against target: |
195 lines (+34/-21) 5 files modified
app/app.js (+2/-1) app/assets/javascripts/bundle-import-helpers.js (+9/-3) app/store/env/go.js (+11/-7) app/subapps/browser/views/bundle.js (+1/-1) test/test_bundle_import_helpers.js (+11/-9) |
To merge this branch: | bzr merge lp:~bac/juju-gui/send-bundle-id-to-deployer |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Juju GUI Hackers | Pending | ||
Review via email: mp+195598@code.launchpad.net |
Description of the change
Send the bundle ID when deploying.
By sending the bundle ID to the server, the deployment statistics can be
updated on Charmworld for that bundle.
QA:
In the latest charm trunk:
% juju switch ec2
% juju bootstrap
% make deploy
% juju set juju-gui "juju-gui-source=lp:~bac/juju-gui/send-bundle-id-to-deployer"
% juju set juju-gui "charmworld-url=http://
Search for a simple bundle. Jorge's are good. In this example I'll use mediawiki-simple.
Look at the bundle on staging:
http://
Note the Downloads statistics.
Go to your juju-gui instance on ec2.
Search for jorge.
Pick the bundle you want (mediawiki-simple in this case).
Deploy it.
Only when all service are successfully deployed, green, and relations built
will the deployment statistics get updated. At that time go back to staging
and see that the downloads have been incremented.
Reviewers: mp+195598_ code.launchpad. net,
Message:
Please take a look.
Description:
Send the bundle ID when deploying.
By sending the bundle ID to the server, the deployment statistics can be
updated on Charmworld for that bundle.
QA:
In the latest charm trunk: staging. jujucharms. com"
% juju switch ec2
% juju bootstrap
% make deploy
% juju set juju-gui
"juju-gui-source=lp:~bac/juju-gui/send-bundle-id-to-deployer"
% juju set juju-gui "charmworld-url=http://
Search for a simple bundle. Jorge's are good. In this example I'll use
mediawiki-simple.
Look at the bundle on staging: staging. jujucharms. com/bundle/ ~jorge/ mediawiki- simple/ mediawiki- simple
http://
Note the Downloads statistics.
Go to your juju-gui instance on ec2.
Search for jorge.
Pick the bundle you want (mediawiki-simple in this case).
Deploy it.
Only when all service are successfully deployed, green, and relations
built
will the deployment statistics get updated. At that time go back to
staging
and see that the downloads have been incremented.
https:/ /code.launchpad .net/~bac/ juju-gui/ send-bundle- id-to-deployer/ +merge/ 195598
(do not edit description out of merge proposal)
Please review this at https:/ /codereview. appspot. com/28440043/
Affected files (+26, -14 lines): javascripts/ bundle- import- helpers. js browser/ views/bundle. js bundle_ import_ helpers. js
A [revision details]
M app/app.js
M app/assets/
M app/store/env/go.js
M app/subapps/
M test/test_
Index: [revision details]
=== added file '[revision details]'
--- [revision details] 2012-01-01 00:00:00 +0000
+++ [revision details] 2012-01-01 00:00:00 +0000
@@ -0,0 +1,2 @@
+Old revision: <email address hidden>
+New revision: <email address hidden>
Index: app/app.js
importHelper s.deployBundle(
Y.JSON. stringify( {
bundle: bundle
=== modified file 'app/app.js'
--- app/app.js 2013-11-15 13:46:35 +0000
+++ app/app.js 2013-11-18 13:27:49 +0000
@@ -595,13 +595,14 @@
// Grab a reference of these for the nested event calls below.
var env = this.env;
var db = this.db;
- cfg.deployBundle = function(bundle) {
+ cfg.deployBundle = function(bundle, bundleId) {
// The other views will hand us an Object vs a YAML string. The
import
// helpers want the yaml string instead.
}),
+ bundleId,
env,
db
);
Index: test/test_ bundle_ import_ helpers. js bundle_ import_ helpers. js' bundle_ import_ helpers. js 2013-11-15 13:46:35 +0000 bundle_ import_ helpers. js 2013-11-18 13:57:40 +0000
=== modified file 'test/test_
--- test/test_
+++ test/test_
@@ -55,7 +55,7 @@
};
// Start the process by deploying the bundle. s.deployBundle( 'test bundle', env, db); s.deployBundle( 'test bundle', undefined, env, db);
- ns.BundleHelper
+ ns.BundleHelper
});
it('errors when the bundle import fails from the env', function(done) {
@@ -65,14 +65,14 @@
done();
};
- env.deployerImport = function(bundle, name, callback) {
+ env.deployerImport = function(bundle, name, bundleid, callback) {...