lp:~bac/juju-gui/button-radii-2

Created by Brad Crittenden and last modified
Get this branch:
bzr branch lp:~bac/juju-gui/button-radii-2
Only Brad Crittenden can upload to this branch. If you are Brad Crittenden please log in for upload directions.

Branch merges

Related bugs

Related blueprints

Branch information

Owner:
Brad Crittenden
Project:
juju-gui
Status:
Merged

Recent revisions

229. By Brad Crittenden

Button CSS tweaks from Matt

228. By Francesco Banconi

Charm panel description design.

R=bac, gary.poster
CC=
https://codereview.appspot.com/6819098

227. By Gary Poster

Add related charms section to charm description

This adds a related charms section to the charm panel, per UX design.

It adds new functionality to the charm store find method in order to make
the search efficient.

R=benji, francesco.banconi
CC=
https://codereview.appspot.com/6814089

226. By Thiago Veronezi

Filter buttons should match design

The filter buttons should match the design defined by this document:
https://docs.google.com/a/canonical.com/file/d/0BwQq-CeM0Yiod3lacmNqRm43a2s/edit

The filters should use the buttons only. We will not implement the dropdowm version.

R=
CC=
https://codereview.appspot.com/6733060

225. By Brad Crittenden

Fix Makefile error wrt spritegen

If app/assets/sprite exists then regenerating sprites failed since the
logic assumed the directory would not be there. Remove the directory
before copying the contents of the newly generated sprite data.

Self-reviewed.

R=
CC=
https://codereview.appspot.com/6814092

224. By Brad Crittenden

Use two radius button borders.

* Further enhancement of CSS defined buttons.

* Expanded the README to explicitly state where the server can be
  accessed when run locally. This was in response to a confused user
  in IRC.

223. By Brad Crittenden

CSS styling for buttons

* Apply CSS styling to buttons to get them closer to the visual design
  assets.

* Add a top-level rule to specify font-family which is needed to
  override the bootstrap setting rule.

* Drive-by: remove redundant 'font-family' rules.

* Drive-by: fix lint-yuidoc.

R=thiago, gary.poster
CC=
https://codereview.appspot.com/6811062

222. By Nicola Larosa

Add the README to the docs.

Add the README to the docs by symlinking it from the docs directory,
integrating it into the docs index, and adjusting it to better fit
with the rest.

R=bac, gary.poster
CC=
https://codereview.appspot.com/6820071

221. By Gary Poster

Convert charm popup to full side display panel

This makes relatively small changes to adjust the existing charm store panels to be displayed down the full right side, per design specs. It does not touch the display of the panels themselves, other than to adjust the scrolling.

Per reviews, some name normalization occurred as well (e.g., "panel" became "popup" in various names).

R=thiago.veronezi, bac
CC=
https://codereview.appspot.com/6775058

220. By Gary Poster

Change charm search to use HTML5 placeholder

CSS does not allow you to specify a selector for a dynamic empty (or not empty) field value. The two approaches around it I found are JS and required/:valid. I chose required/:valid because it required no JS and seemed simpler. However, this required a CSS workaround: bootstrap wants to highlight focused invalid fields with a red glow. I changed this to have the usual blue glow in the case of this one field.

R=bac, benjamin.saller
CC=
https://codereview.appspot.com/6816046

Branch metadata

Branch format:
Branch format 7
Repository format:
Bazaar repository format 2a (needs bzr 1.16 or later)
Stacked on:
lp:juju-gui/experimental
This branch contains Public information 
Everyone can see this information.

Subscribers