Code LGTM, didn't QA yet, but can if needed
https://codereview.appspot.com/9024045/diff/1/app/plugins/textarea-autosize.js File app/plugins/textarea-autosize.js (right):
https://codereview.appspot.com/9024045/diff/1/app/plugins/textarea-autosize.js#newcode46 app/plugins/textarea-autosize.js:46: //textarea.on('input', this._autoSizeHandler, this); Remove or add comment as to why this is commented out.
https://codereview.appspot.com/9024045/diff/1/app/plugins/textarea-autosize.js#newcode141 app/plugins/textarea-autosize.js:141: // this.mirrorElement.value = textarea.value + options.append; Remove or explain.
https://codereview.appspot.com/9024045/diff/1/app/plugins/textarea-autosize.js#newcode173 app/plugins/textarea-autosize.js:173: // XXX: The original had a very short timeout to avoid IE wetting This seems like a safe enough flag to have around, but will defer to others.
https://codereview.appspot.com/9024045/
« Back to merge proposal
Code LGTM, didn't QA yet, but can if needed
https:/ /codereview. appspot. com/9024045/ diff/1/ app/plugins/ textarea- autosize. js textarea- autosize. js (right):
File app/plugins/
https:/ /codereview. appspot. com/9024045/ diff/1/ app/plugins/ textarea- autosize. js#newcode46 textarea- autosize. js:46: //textarea. on('input' , andler, this);
app/plugins/
this._autoSizeH
Remove or add comment as to why this is commented out.
https:/ /codereview. appspot. com/9024045/ diff/1/ app/plugins/ textarea- autosize. js#newcode141 textarea- autosize. js:141: // this.mirrorElem ent.value =
app/plugins/
textarea.value + options.append;
Remove or explain.
https:/ /codereview. appspot. com/9024045/ diff/1/ app/plugins/ textarea- autosize. js#newcode173 textarea- autosize. js:173: // XXX: The original had a very
app/plugins/
short timeout to avoid IE wetting
This seems like a safe enough flag to have around, but will defer to
others.
https:/ /codereview. appspot. com/9024045/