lp:~bac/juju-gui/autosize-plugin

Branch merges

Propose for merging

No branches dependent on this one.

Ready for review for merging into lp:juju-gui/experimental

Juju GUI Hackers: Pending requested 2013-04-30

Diff: 339 lines (+289/-0)

5 files modified

Makefile (+2/-0)
app/modules-debug.js (+5/-0)
app/plugins/textarea-autosize.js (+191/-0)
test/index.html (+1/-0)
test/test_textarea_autosize.js (+90/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

633. By Brad Crittenden on 2013-04-30

lint

632. By Brad Crittenden on 2013-04-30

Remove describe.only

631. By Brad Crittenden on 2013-04-30

More tests

630. By Brad Crittenden on 2013-04-30

wire up autosize tests

629. By Brad Crittenden on 2013-04-30

Added NS to plugin

628. By Brad Crittenden on 2013-04-30

Add app/plugins

627. By Brad Crittenden on 2013-04-30

Added textarea autosize plugin

626. By Richard Harding on 2013-04-30

TRIVIAL - google fonts over https

- One letter diff ftw.

R=
CC=
https://codereview.appspot.com/9046043

625. By Richard Harding on 2013-04-29

Adds filter controls to the search in the browser

- The branch updates the models/browser.js Filter model that is basically the
search state in the application.
- The subapp keeps an instance of that around and updates it along with the
rest of the subapplication state.
- The subapp passes the raw data down into views that can use it to populate
the search related widgets (search and filters).
- When those widgets are changed they trigger a custom event back up to their
controlling View.
- That View then generates a change event to the subapp directing it to update
it's current _filter (the Filter model) with that change and navigate to the
new url.
- All searches are url-able and thus force a navigate and re-process through
the render chain.
- Because of this, the Views do not need to update their version of the
filters, they'll get new ones from the subapp on the next routing.

Known QA issues:

- There's not a good "no results found" display
- There's not a list of selected filters per UX design when the filter list is
collapsed in sidebar view
- Theme'ing needs to be done on the filter list to remove the leading *, make
things more header-like, add proper arrows vs temp ^/v
- It's felt these are correctable through the week while the functionality is
able to be added before 'feature freeze' on Monday.

R=j.c.sackett, benji
CC=
https://codereview.appspot.com/9003043

624. By Richard Harding on 2013-04-29

Adjust badge on larger icon due to radius.

R=
CC=
https://codereview.appspot.com/8853049