Merge lp:~bac/juju-gui/1083933 into lp:juju-gui/experimental
Proposed by
Brad Crittenden
Status: | Merged |
---|---|
Merged at revision: | 316 |
Proposed branch: | lp:~bac/juju-gui/1083933 |
Merge into: | lp:juju-gui/experimental |
Diff against target: |
140 lines (+87/-14) 3 files modified
app/views/topology/viewport.js (+1/-14) test/index.html (+1/-0) test/test_viewport_module.js (+85/-0) |
To merge this branch: | bzr merge lp:~bac/juju-gui/1083933 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Juju GUI Hackers | Pending | ||
Review via email: mp+143120@code.launchpad.net |
Description of the change
Add tests for new viewport module.
Add tests for the new module. Also removed an unused function. It looked
useful but I didn't think it should hang around if not called. Ben might have
had a plan for it.
To post a comment you must log in.
Reviewers: mp+143120_ code.launchpad. net,
Message:
Please take a look.
Description:
Add tests for new viewport module.
Add tests for the new module. Also removed an unused function. It
looked
useful but I didn't think it should hang around if not called. Ben
might have
had a plan for it.
https:/ /code.launchpad .net/~bac/ juju-gui/ 1083933/ +merge/ 143120
(do not edit description out of merge proposal)
Please review this at https:/ /codereview. appspot. com/7085057/
Affected files: topology/ viewport. js viewport_ module. js
A [revision details]
M app/views/
M test/index.html
A test/test_