Merge lp:~bac/juju-core/master into lp:~juju/juju-core/trunk

Proposed by Brad Crittenden
Status: Work in progress
Proposed branch: lp:~bac/juju-core/master
Merge into: lp:~juju/juju-core/trunk
Diff against target: 0 lines
To merge this branch: bzr merge lp:~bac/juju-core/master
Reviewer Review Type Date Requested Status
The Go Language Gophers Pending
Review via email: mp+150398@code.launchpad.net

Description of the change

Add API support for ServiceGet

Server and client support for ServiceGet with tests.

To post a comment you must log in.
Revision history for this message
Dave Cheney (dave-cheney) wrote :

@bac, did you use lbox for this review? It looks empty too me.

Unmerged revisions

928. By William Reade

trivial: use more realistic series...

...in places where they will be needed.

R=TheMue, dimitern, rog
CC=
https://codereview.appspot.com/7403050

927. By Dimiter Naydenov

uniter: skip unknown rel. endpoints

Ignore relations with unknown (not implemented by
the charm) when handling upgrades.
The uniter is now requesting all relation events
on upgrade, so they won't be missed.

This also fixes LP bug #1101140 (uniter does not
skip unimplemented relations).

R=fwereade, TheMue
CC=
https://codereview.appspot.com/7385049

926. By Ian Booth

Config for assigning public (floating) IP to nodes

A new config key, use-floating-ip (default true), is provided. If true, nodes are given a public IP address.

When adding new tests, I ran into the problem that some existing tests rely on state created by other tests. I fixed this and
also removed unnecessary Env duplication in the local live tests.

R=dimitern, jameinel
CC=
https://codereview.appspot.com/7397047

925. By Tim Penhey

Change the way aliases to subcommands are handled.

The primary motivation for this change is to be able to list all the
aliases for a command when asking for help on that command.

This led to changes in the way the command aliases work, and where the aliases
are stored. The commands now specify their own aliases rather than them being
specified when the command is added to the super command.

R=dfc, dimitern, rog, fwereade
CC=
https://codereview.appspot.com/7370043

924. By Dave Cheney

version: update development version to 1.9.10

Also, gofmt

R=
CC=
https://codereview.appspot.com/7400051

923. By Frank Mueller

local: add storage

Added environ.Storage implementation using the local
storage backend. The tests so far are a copy from
environs/jujutest to check if the behavior is adequate.

R=dimitern, fwereade
CC=
https://codereview.appspot.com/7346052

922. By Dimiter Naydenov

uniter: WantAllRelationsEvents() filter

This is the first CL in preparation for the
implementation of upgrade-charm. Here, we'll
prepare the Uniter to handle upgrades better,
by restarting the relations watcher in the
filter, when requested with WantAllRelationsEvents().

R=fwereade, TheMue
CC=
https://codereview.appspot.com/7373046

921. By Frank Mueller

local: added storage backend

Added a small web server acting as storage backend.

R=fwereade, dimitern
CC=
https://codereview.appspot.com/7303097

920. By Brad Crittenden

Refactor guts of cmd/juju/get/Run to statecmd.

This is the first of two branches to provide API support for 'juju get'. This
one does the preliminary work of moving the common code to statecmd. The next
branch will add support in client and apiserver.

Did some drive-by changes including typo fixes that were visible in output and
added some content to the README.

R=dfc, jameinel, dimitern, fwereade
CC=
https://codereview.appspot.com/7401043

919. By William Reade

state: add Machine.Series

as a very first step towards resolving lp:1131608

R=TheMue, dimitern
CC=
https://codereview.appspot.com/7399049

Preview Diff

Empty

Subscribers

People subscribed via source and target branches