Brad--
Thanks, just one minor note.
https://codereview.appspot.com/158010043/diff/1/charmworld/search.py File charmworld/search.py (right):
https://codereview.appspot.com/158010043/diff/1/charmworld/search.py#newcode701 charmworld/search.py:701: hits = hits[start:] If there's an ElasticHttpError hits will be []; couldn't this then throw an IndexError?
Perhaps this should be in the try: block above.
https://codereview.appspot.com/158010043/
« Back to merge proposal
Brad--
Thanks, just one minor note.
https:/ /codereview. appspot. com/158010043/ diff/1/ charmworld/ search. py search. py (right):
File charmworld/
https:/ /codereview. appspot. com/158010043/ diff/1/ charmworld/ search. py#newcode701 search. py:701: hits = hits[start:]
charmworld/
If there's an ElasticHttpError hits will be []; couldn't this then throw
an IndexError?
Perhaps this should be in the try: block above.
https:/ /codereview. appspot. com/158010043/