Code review comment for lp:~bac/charms/precise/juju-gui/increment-deployments

Revision history for this message
Brad Crittenden (bac) wrote :

*** Submitted:

After deploying a bundle increment counter.

The guiserver will make a GET request to the deployment counter
incrementer
URL for the bundle. This required accepting the bundle ID in the
Deployer/Import path.

Note neither the GUI nor quickstart have been updated to pass this value
yet.

The charmworldurl is also now passed to the server via the command line.

QA: just deploy your favorite bundle and see that it works as it should.
  You
can observe the bundle page in charmworld and see the counts remain at
0.

R=frankban
CC=
https://codereview.appspot.com/26740043

https://codereview.appspot.com/26740043/diff/20001/server/guiserver/bundles/base.py
File server/guiserver/bundles/base.py (right):

https://codereview.appspot.com/26740043/diff/20001/server/guiserver/bundles/base.py#newcode188
server/guiserver/bundles/base.py:188: if bundle_id is not None and error
is None:
On 2013/11/15 14:42:03, frankban wrote:
> I the future has been cancelled then error is not defined here.

Done.

https://codereview.appspot.com/26740043/

« Back to merge proposal