Merge lp:~bac/charms/precise/juju-gui/ga-key into lp:~juju-gui/charms/precise/juju-gui/trunk
Proposed by
Brad Crittenden
Status: | Merged |
---|---|
Merged at revision: | 107 |
Proposed branch: | lp:~bac/charms/precise/juju-gui/ga-key |
Merge into: | lp:~juju-gui/charms/precise/juju-gui/trunk |
Diff against target: |
125 lines (+15/-19) 5 files modified
config.yaml (+7/-6) config/config.js.template (+1/-1) hooks/backend.py (+1/-1) hooks/utils.py (+3/-3) tests/test_utils.py (+3/-8) |
To merge this branch: | bzr merge lp:~bac/charms/precise/juju-gui/ga-key |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Richard Harding | Approve | ||
charmers | Pending | ||
Review via email: mp+185294@code.launchpad.net |
Description of the change
Make the Google Analytics key configurable.
To QA you can do the following:
(cd $HOME/charms/
juju bootstrap -e goec2 --upload-tools
juju deploy -e goec2 --to 0 --repository=
juju set juju-gui juju-gui-source=lp:~bac/juju-gui/ga-key
juju expose -e goec2 juju-gui
When everything is happy you can confirm the old key is in use by:
juju get juju-gui
And verify the ga-key is the old one: UA-41463568-2
Change the key with
juju set juju-gui "ga-key=
Now if you deploy a service using a novel name like "apache-bac" we should see that event appear in the GA logs.
To post a comment you must log in.
QA ok
#16 double space in there
Just a heads up, I found it easier to test with instructions I've gotten from francesco before:
- bzr branch .... bac-ga-key UA-1018242- 44"
- cd ...
- make deploy
- Now make the config change with juju set juju-gui "ga-key=
- Verify that the key is changed in the window.juju_config