Merge ~b-stolk/chromium-browser/+git/snap-from-source:checkdriverpath into ~chromium-team/chromium-browser/+git/snap-from-source:hwacc-beta
Proposed by
Bram Stolk
Status: | Rejected |
---|---|
Rejected by: | Nathan Teodosio |
Proposed branch: | ~b-stolk/chromium-browser/+git/snap-from-source:checkdriverpath |
Merge into: | ~chromium-team/chromium-browser/+git/snap-from-source:hwacc-beta |
Diff against target: |
43 lines (+29/-0) 2 files modified
build/chromium-patches/extra:885da2c:check-for-empty-define.diff (+28/-0) build/chromium-patches/series (+1/-0) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Nathan Teodosio | Needs Information | ||
Review via email: mp+437529@code.launchpad.net |
Commit message
Avoid un-expanded DRI_DRIVER_DIR macro.
If DRI_DRIVER_DIR is not defined, as currently is the case in
our build, then the chrome binary with minigbm support will
attempt to load DRI_DRIVER_
the variable. This has severe consequences.
This patch will set it to /usr/lib/
macro is not defined.
Fixes LP:2004586
Description of the change
This change can be applied to all hwacc branches.
To post a comment you must log in.
This merge request patches amdgpu.c directly to "hard-define" DRI_DRIVER_DIR, which a single direct step away from the direct patch your partner proposed in the description of the linked bug report.
LP:2004586 --->
> But it is better to understand why this expansion failed.
> And it is possibly fixed in later chromium releases, if not, we should look how our snap building differs from the official Linux building instructions for chromium.
<---
If we want to better understand why the expansion failed, we need to actually understand why DRI_DRIVER_DIR is not defined, and thus why build/config/ linux/pkg- config. py fails to find dridriverdir. Do you agree?
LP:2004586 --->
> I've verified that this can be fixed by adding a configuration to minigbm's BUILD.gn
<---
What would that fix be?