Merge ~b-stolk/chromium-browser/+git/snap-from-source:hwacc-dev into ~chromium-team/chromium-browser/+git/snap-from-source:hwacc-dev

Proposed by Bram Stolk
Status: Merged
Approved by: Nathan Teodosio
Approved revision: 9e4e533f155282b45cd2dd8754d8b565a2e95ce4
Merged at revision: 4c051e7082153f898e46e27d56466ae497cbfdfe
Proposed branch: ~b-stolk/chromium-browser/+git/snap-from-source:hwacc-dev
Merge into: ~chromium-team/chromium-browser/+git/snap-from-source:hwacc-dev
Diff against target: 25 lines (+6/-0) (has conflicts)
1 file modified
launcher/chromium.launcher (+6/-0)
Conflict in launcher/chromium.launcher
Reviewer Review Type Date Requested Status
Nathan Teodosio Approve
Review via email: mp+435086@code.launchpad.net

Description of the change

This uses the proper syntax for the --enable-hardware-overlays flag.

The syntax changed four years ago.
See: https://codereview.chromium.org/2657633002

To post a comment you must log in.
Revision history for this message
Nathan Teodosio (nteodosio) :
Revision history for this message
Bram Stolk (b-stolk) :
Revision history for this message
Nathan Teodosio (nteodosio) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/launcher/chromium.launcher b/launcher/chromium.launcher
2index d450839..fd3fe67 100755
3--- a/launcher/chromium.launcher
4+++ b/launcher/chromium.launcher
5@@ -111,7 +111,11 @@ if [ $WANT_HEADLESS -eq 0 ] ; then
6 fi
7
8 # Add necessary flags for VAAPI video en/decoding
9+<<<<<<< launcher/chromium.launcher
10 CHROMIUM_VAAPI_FLAGS='--enable-features=VaapiVideoDecoder,VaapiVideoEncoder --disable-features=UseChromeOSDirectVideoDecoder --enable-hardware-overlays="" --video-capture-use-gpu-memory-buffer --use-gl=egl --video-capture-use-external-dma-buffer'
11+=======
12+CHROMIUM_VAAPI_FLAGS='--enable-features=VaapiVideoDecoder,VaapiVideoEncoder --disable-features=UseChromeOSDirectVideoDecoder --video-capture-use-gpu-memory-buffer --use-gl=egl --video-capture-use-external-dma-buffer'
13+>>>>>>> launcher/chromium.launcher
14
15 if [ -n "$WAYLAND_DISPLAY" ]; then
16 CHROMIUM_VAAPI_FLAGS="--ozone-platform=wayland $CHROMIUM_VAAPI_FLAGS"
17@@ -119,6 +123,8 @@ fi
18
19 CHROMIUM_FLAGS="--disable-features=TFLiteLanguageDetectionEnabled $CHROMIUM_FLAGS"
20
21+CHROMIUM_FLAGS="--enable-hardware-overlays=single-fullscreen,single-on-top,underlay $CHROMIUM_FLAGS"
22+
23 if [ $WANT_TEMP_PROFILE -eq 0 ] ; then
24 exec "$SNAP/usr/lib/chromium-browser/chrome" --password-store=$PASSWORD_STORE $CHROMIUM_VAAPI_FLAGS $CHROMIUM_FLAGS "$@"
25 else

Subscribers

People subscribed via source and target branches

to status/vote changes: