cloud-init

Merge ~b-candler/cloud-init:avalid-seed into cloud-init:master

  1. Git
  2. lp:~b-candler/cloud-init
  3. avalid-seed
  4. Merge into master
Proposed by Brian Candler
Status: Merged
Approved by: Dan Watkins
Approved revision: ec104f64b2328bc16b7386104f39a105889288b4
Merge reported by: Server Team CI bot
Merged at revision: not available
Proposed branch: ~b-candler/cloud-init:avalid-seed
Merge into: cloud-init:master
Diff against target: 12 lines (+1/-1)
1 file modified
cloudinit/sources/DataSourceNoCloud.py (+1/-1)
Reviewer Review Type Date Requested Status
Server Team CI bot continuous-integration Approve
Dan Watkins Approve
Review via email: mp+373132@code.launchpad.net

Commit message

Add missing space in warning: "not avalid seed"

Description of the change

Trivial change to fix missing space in warning message

To post a comment you must log in.
Revision history for this message
Dan Watkins (oddbloke) wrote :

Good spot, thanks for the fix! I've just kicked off CI, and once that passes we can land this.

review: Approve
Revision history for this message
Server Team CI bot (server-team-bot) wrote :

FAILED: Continuous integration, rev:ec104f64b2328bc16b7386104f39a105889288b4
https://jenkins.ubuntu.com/server/job/cloud-init-ci/1172/
Executed test runs:
    SUCCESS: Checkout
    FAILED: Unit & Style Tests

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/1172//rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Server Team CI bot (server-team-bot) wrote :

FAILED: Continuous integration, rev:ec104f64b2328bc16b7386104f39a105889288b4
https://jenkins.ubuntu.com/server/job/cloud-init-ci/1173/
Executed test runs:
    SUCCESS: Checkout
    FAILED: Unit & Style Tests

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/1173//rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Dan Watkins (oddbloke) wrote :

OK, it looks like we're seeing pylint failures in master, which is causing these failures. I'm looking into it.

Revision history for this message
Server Team CI bot (server-team-bot) wrote :

FAILED: Continuous integration, rev:ec104f64b2328bc16b7386104f39a105889288b4
https://jenkins.ubuntu.com/server/job/cloud-init-ci/1174/
Executed test runs:
    SUCCESS: Checkout
    FAILED: Unit & Style Tests

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/1174//rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Server Team CI bot (server-team-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/cloudinit/sources/DataSourceNoCloud.py b/cloudinit/sources/DataSourceNoCloud.py
2index 8a9e5dd..474773d 100644
3--- a/cloudinit/sources/DataSourceNoCloud.py
4+++ b/cloudinit/sources/DataSourceNoCloud.py
5@@ -127,7 +127,7 @@ class DataSourceNoCloud(sources.DataSource):
6 seeded = util.mount_cb(dev, _pp2d_callback,
7 pp2d_kwargs)
8 except ValueError:
9- LOG.warning("device %s with label=%s not a"
10+ LOG.warning("device %s with label=%s not a "
11 "valid seed.", dev, label)
12 continue
13

Subscribers

People subscribed via source and target branches