Code review comment for lp:~azzar1/update-notifier/livepatch-notification-button

Revision history for this message
Andrea Azzarone (azzar1) wrote :

> Thank you for your work, that looks mostly fine, I'm unsure why you add the
> action twice though?
>
> + if (info) {
> + notify_notification_add_action (n, "settings", _("Show Settings…"),
> + notify_action_cb, NULL, NULL);
> + notify_notification_add_action (n, "default", _("Show Settings…"),
> + notify_action_cb, NULL, NULL);
>
> Wouldn't one be enough?

One is to add a button, one is to open software properties if you click on the notification.

« Back to merge proposal