Code review comment for lp:~azzar1/update-notifier/livepatch-indicator

Revision history for this message
Andrea Azzarone (azzar1) wrote :

> Building there is this warning, unsure if it can be avoided or if that's the
> compiler not understanding the g_autoptr thing?
>
> 'livepatch-utils.c: In function ‘livepatch_is_supported’:
> /usr/include/glib-2.0/glib/gmacros.h:523:10: warning: ‘keys’ may be used
> uninitialized in this function [-Wmaybe-uninitialized]
> { if (_ptr) (cleanup) ((ParentName *) _ptr); }
> \
> ^
> livepatch-utils.c:42:25: note: ‘keys’ was declared here
> g_autoptr(GKeyFile) keys;
> ^~~~'

Fixed.

> Otherwise looks good, one small comment ... can you change the copyrights to
> be Canonical?

Fixed.

« Back to merge proposal