Merge lp:~azzar1/unity/lp-1320438 into lp:unity

Proposed by Andrea Azzarone
Status: Merged
Approved by: Marco Trevisan (Treviño)
Approved revision: no longer in the source branch.
Merged at revision: 3819
Proposed branch: lp:~azzar1/unity/lp-1320438
Merge into: lp:unity
Diff against target: 18 lines (+6/-2)
1 file modified
plugins/unityshell/src/unityshell.cpp (+6/-2)
To merge this branch: bzr merge lp:~azzar1/unity/lp-1320438
Reviewer Review Type Date Requested Status
Marco Trevisan (Treviño) Approve
PS Jenkins bot (community) continuous-integration Needs Fixing
Review via email: mp+220950@code.launchpad.net

Commit message

Pass the correct options to showLauncherKeyTerminate in UnityScreen::OnLockScreen

Description of the change

== Problem ==
Unity launcher auto hide fails on screen unlock using "Super+L"

== Fix ==
Pass the correct options to showLauncherKeyTerminate in UnityScreen::OnLockScreen.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:3807
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~andyrock/unity/lp-1320438/+merge/220950/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/unity-ci/931/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-utopic-amd64-ci/18
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-utopic-armhf-ci/18
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-utopic-i386-ci/18

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-ci/931/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plugins/unityshell/src/unityshell.cpp'
2--- plugins/unityshell/src/unityshell.cpp 2014-05-12 22:01:39 +0000
3+++ plugins/unityshell/src/unityshell.cpp 2014-05-26 12:24:27 +0000
4@@ -3826,8 +3826,12 @@
5 screen->removeAction(&action);
6
7 // We notify that super/alt have been released, to avoid to leave unity in inconsistent state
8- showLauncherKeyTerminate(&optionGetShowLauncher(), CompAction::StateTermKey, getOptions());
9- showMenuBarTerminate(&optionGetShowMenuBar(), CompAction::StateTermKey, getOptions());
10+ CompOption::Vector options(8);
11+ options[7].setName("time", CompOption::TypeInt);
12+ options[7].value().set((int) screen->getCurrentTime());
13+
14+ showLauncherKeyTerminate(&optionGetShowLauncher(), CompAction::StateTermKey, options);
15+ showMenuBarTerminate(&optionGetShowMenuBar(), CompAction::StateTermKey, options);
16 }
17
18 void UnityScreen::OnScreenUnlocked()