Merge lp:~azzar1/unity/lp-1233666 into lp:unity

Proposed by Andrea Azzarone
Status: Merged
Approved by: Brandon Schaefer
Approved revision: no longer in the source branch.
Merged at revision: 3547
Proposed branch: lp:~azzar1/unity/lp-1233666
Merge into: lp:unity
Diff against target: 19 lines (+2/-1)
1 file modified
launcher/Launcher.cpp (+2/-1)
To merge this branch: bzr merge lp:~azzar1/unity/lp-1233666
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Brandon Schaefer (community) Approve
Review via email: mp+188689@code.launchpad.net

Commit message

Update icon_under_mouse before process mouse movemnt in the tooltip manager.

Description of the change

== Problem ==
Bug #1233666: AP failure: test_launcher_tooltip_disabling

== Fix ==
Update icon_under_mouse before process mouse movement in the tooltip manager.

== Test ==
There is/was already a failing AP test.

To post a comment you must log in.
Revision history for this message
Brandon Schaefer (brandontschaefer) wrote :

LGTM

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'launcher/Launcher.cpp'
2--- launcher/Launcher.cpp 2013-09-19 13:00:42 +0000
3+++ launcher/Launcher.cpp 2013-10-01 18:46:13 +0000
4@@ -2226,13 +2226,14 @@
5 void Launcher::RecvMouseMove(int x, int y, int dx, int dy, unsigned long button_flags, unsigned long key_flags)
6 {
7 SetMousePosition(x, y);
8- tooltip_manager_.MouseMoved(icon_under_mouse_);
9
10 if (!hidden_)
11 UpdateChangeInMousePosition(dx, dy);
12
13 // Every time the mouse moves, we check if it is inside an icon...
14 EventLogic();
15+
16+ tooltip_manager_.MouseMoved(icon_under_mouse_);
17 }
18
19 void Launcher::RecvMouseWheel(int /*x*/, int /*y*/, int wheel_delta, unsigned long /*button_flags*/, unsigned long key_flags)