Unity

Merge lp:~azzar1/unity/lp-1233195 into lp:unity

  1. lp-1233195
  2. Merge into trunk
Proposed by Andrea Azzarone
Status: Merged
Approved by: Brandon Schaefer
Approved revision: no longer in the source branch.
Merged at revision: 3546
Proposed branch: lp:~azzar1/unity/lp-1233195
Merge into: lp:unity
Diff against target: 11 lines (+1/-0)
1 file modified
unity-shared/PlacesOverlayVScrollBar.cpp (+1/-0)
To merge this branch: bzr merge lp:~azzar1/unity/lp-1233195
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Brandon Schaefer (community) Approve
Review via email: mp+188445@code.launchpad.net

Commit message

Fix bad redrawing of dash overlay scrollbar connector.

Description of the change

== Problem ==
[Regression] Bad redraw of the dash overlay connector.

== Fix ==
Call ResetConnector when the overlay_window_ is completly hidden.

To post a comment you must log in.
Revision history for this message
Brandon Schaefer (brandontschaefer) wrote :

LGTM

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:3544
http://jenkins.qa.ubuntu.com/job/unity-ci/410/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-saucy-amd64-ci/299
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-saucy-armhf-ci/297
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-saucy-i386-ci/298

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-ci/410/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'unity-shared/PlacesOverlayVScrollBar.cpp'
2--- unity-shared/PlacesOverlayVScrollBar.cpp 2013-07-18 02:51:34 +0000
3+++ unity-shared/PlacesOverlayVScrollBar.cpp 2013-09-30 20:29:46 +0000
4@@ -53,6 +53,7 @@
5 overlay_window_->mouse_click.connect(sigc::mem_fun(this, &PlacesOverlayVScrollBar::OnMouseClick));
6 overlay_window_->mouse_move.connect(sigc::mem_fun(this, &PlacesOverlayVScrollBar::OnMouseMove));
7 overlay_window_->mouse_drag.connect(sigc::mem_fun(this, &PlacesOverlayVScrollBar::OnMouseDrag));
8+ overlay_window_->sigHidden.connect(sigc::hide(sigc::mem_fun(this, &PlacesOverlayVScrollBar::ResetConnector)));
9
10 _track->geometry_changed.connect(sigc::mem_fun(this, &PlacesOverlayVScrollBar::OnTrackGeometryChanged));
11 OnVisibleChanged.connect(sigc::mem_fun(this, &PlacesOverlayVScrollBar::OnVisibilityChanged));