Unity

Merge lp:~azzar1/unity/lp-1181717 into lp:unity

  1. lp-1181717
  2. Merge into trunk
Proposed by Andrea Azzarone
Status: Merged
Approved by: Marco Trevisan (Treviño)
Approved revision: no longer in the source branch.
Merged at revision: 3355
Proposed branch: lp:~azzar1/unity/lp-1181717
Merge into: lp:unity
Diff against target: 12 lines (+1/-1)
1 file modified
unity-shared/BamfApplicationManager.cpp (+1/-1)
To merge this branch: bzr merge lp:~azzar1/unity/lp-1181717
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Marco Trevisan (Treviño) Approve
Review via email: mp+166926@code.launchpad.net

Commit message

Reference BamfApplication in GetRunningApplications.

Description of the change

== Problem ==
compiz crashed with SIGSEGV in g_object_unref()

== Fix ==
Reference BamfApplication in GetRunningApplications.

To post a comment you must log in.
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

Good catch, it seems that "long time ago" someone missed to do this...

Would be nice to backport this also to raring.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'unity-shared/BamfApplicationManager.cpp'
2--- unity-shared/BamfApplicationManager.cpp 2013-02-05 02:14:32 +0000
3+++ unity-shared/BamfApplicationManager.cpp 2013-06-01 02:20:35 +0000
4@@ -612,7 +612,7 @@
5 continue;
6 }
7
8- glib::Object<BamfApplication> bamf_app(static_cast<BamfApplication*>(l->data));
9+ glib::Object<BamfApplication> bamf_app(static_cast<BamfApplication*>(l->data), glib::AddRef());
10 ApplicationPtr app(new Application(*this, bamf_app));
11 result.push_back(app);
12 LOG_DEBUG(logger) << "Running app: " << app->title();