Unity

Merge lp:~azzar1/unity/lp-1170715 into lp:~unity-team/unity/libunity-7.0-breakage

  1. lp-1170715
  2. Merge into libunity-7.0-breakage
Proposed by Andrea Azzarone
Status: Merged
Approved by: Michal Hruby
Approved revision: no longer in the source branch.
Merged at revision: 3123
Proposed branch: lp:~azzar1/unity/lp-1170715
Merge into: lp:~unity-team/unity/libunity-7.0-breakage
Diff against target: 27 lines (+10/-8)
1 file modified
dash/previews/ApplicationPreview.cpp (+10/-8)
To merge this branch: bzr merge lp:~azzar1/unity/lp-1170715
Reviewer Review Type Date Requested Status
Michal Hruby (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+160401@code.launchpad.net

Commit message

Allow disabling PreviewRatingsWidget for ApplicationPreviews.

Description of the change

== Problem ==
Search Plugins previews in the apps lens should not display any 'review stars'

== Fix ==
Allow disabling PreviewRatingsWidget for ApplicationPreviews.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:3120
http://jenkins.qa.ubuntu.com/job/unity-team-unity-libunity-7.0-breakage-ci/56/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-team-unity-libunity-7.0-breakage-raring-amd64-ci/56

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-team-unity-libunity-7.0-breakage-ci/56/rebuild

review: Approve (continuous-integration)
Revision history for this message
Michal Hruby (mhr3) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'dash/previews/ApplicationPreview.cpp'
2--- dash/previews/ApplicationPreview.cpp 2013-01-16 15:43:38 +0000
3+++ dash/previews/ApplicationPreview.cpp 2013-04-23 15:08:36 +0000
4@@ -153,14 +153,16 @@
5 app_icon_->mouse_click.connect(on_mouse_down);
6 icon_layout->AddView(app_icon_.GetPointer(), 0);
7
8- app_rating_ = new PreviewRatingsWidget();
9- AddChild(app_rating_.GetPointer());
10- app_rating_->SetMaximumHeight(style.GetRatingWidgetHeight());
11- app_rating_->SetMinimumHeight(style.GetRatingWidgetHeight());
12- app_rating_->SetRating(app_preview_model->rating);
13- app_rating_->SetReviews(app_preview_model->num_ratings);
14- app_rating_->request_close().connect([this]() { preview_container_->request_close.emit(); });
15- icon_layout->AddView(app_rating_.GetPointer(), 0);
16+ if (app_preview_model->rating >= 0) {
17+ app_rating_ = new PreviewRatingsWidget();
18+ AddChild(app_rating_.GetPointer());
19+ app_rating_->SetMaximumHeight(style.GetRatingWidgetHeight());
20+ app_rating_->SetMinimumHeight(style.GetRatingWidgetHeight());
21+ app_rating_->SetRating(app_preview_model->rating);
22+ app_rating_->SetReviews(app_preview_model->num_ratings);
23+ app_rating_->request_close().connect([this]() { preview_container_->request_close.emit(); });
24+ icon_layout->AddView(app_rating_.GetPointer(), 0);
25+ }
26
27 /////////////////////
28

Subscribers

People subscribed via source and target branches

to all changes: