Merge lp:~azzar1/unity/lp-1055126 into lp:unity

Proposed by Andrea Azzarone on 2013-04-12
Status: Merged
Approved by: Brandon Schaefer on 2013-04-12
Approved revision: 3298
Merged at revision: 3298
Proposed branch: lp:~azzar1/unity/lp-1055126
Merge into: lp:unity
Diff against target: 34 lines (+5/-3)
2 files modified
dash/DashView.cpp (+1/-1)
unity-shared/OverlayRenderer.cpp (+4/-2)
To merge this branch: bzr merge lp:~azzar1/unity/lp-1055126
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve on 2013-04-12
Brandon Schaefer (community) 2013-04-12 Approve on 2013-04-12
Review via email: mp+158667@code.launchpad.net

Commit message

Don't force edge drawing in DashView. Fixes bug 1055126 here.

Description of the change

== Problem ==
Bug #1055126: dash preview animation is slow on high resolution screens (also fullscreen mode).

== Fix ==
Maybe there is a problem with (partially) offscreen texture (I need to investigate better), btw there is no need to force edge drawing in DashView.

== Test ==
N/A.

To post a comment you must log in.
Brandon Schaefer (brandontschaefer) wrote :

Awesome, just a note there are some bluring problems still and possible loading problems at the start that makes it slow. After the lenses have loaded things are faaast :)

review: Approve
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'dash/DashView.cpp'
2--- dash/DashView.cpp 2013-04-10 18:26:42 +0000
3+++ dash/DashView.cpp 2013-04-12 16:20:39 +0000
4@@ -692,7 +692,7 @@
5 renderer_geo.y += panel_style.panel_height;
6 renderer_geo.height += panel_style.panel_height;
7
8- renderer_.DrawFull(graphics_engine, content_geo_, renderer_geo_abs, renderer_geo, true);
9+ renderer_.DrawFull(graphics_engine, content_geo_, renderer_geo_abs, renderer_geo, false);
10 }
11
12 void DashView::DrawContent(nux::GraphicsEngine& graphics_engine, bool force_draw)
13
14=== modified file 'unity-shared/OverlayRenderer.cpp'
15--- unity-shared/OverlayRenderer.cpp 2013-04-09 01:12:21 +0000
16+++ unity-shared/OverlayRenderer.cpp 2013-04-12 16:20:39 +0000
17@@ -800,13 +800,15 @@
18 texxform,
19 nux::color::White);
20 }
21-
22- gfx_context.GetRenderStates().SetBlend(false);
23 }
24
25 gfx_context.PopClippingRectangle();
26 }
27
28+ gfx_context.GetRenderStates().SetPremultipliedBlend(nux::SRC_OVER);
29+ gfx_context.GetRenderStates().SetColorMask(true, true, true, true);
30+ gfx_context.GetRenderStates().SetBlend(false);
31+
32 }
33
34 void OverlayRendererImpl::DrawContent(nux::GraphicsEngine& gfx_context, nux::Geometry const& content_geo, nux::Geometry const& absolute_geo, nux::Geometry const& geometry)