Merge lp:~azzar1/unity/fix-shortcut-overlay-redrawing into lp:unity

[Andrea Azzarone]

Properly hide shortcut overlay window to avoid unnecessary redraws.

Properly hide shortcut overlay window to avoid unnecessary redraws.

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:4037
http://jenkins.qa.ubuntu.com/job/unity-ci/1361/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-xenial-amd64-ci/13
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-xenial-armhf-ci/13
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-xenial-i386-ci/13

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-ci/1361/rebuild

review: Approve (continuous-integration)

[Marco Trevisan (Treviño) (3v1n0)]

+1

review: Approve

=== modified file 'shortcuts/ShortcutController.cpp'
--- shortcuts/ShortcutController.cpp	2014-05-14 00:06:05 +0000
+++ shortcuts/ShortcutController.cpp	2015-11-26 00:11:28 +0000
@@ -53,6 +53,10 @@
 
   WindowManager::Default().average_color.changed.connect(sigc::mem_fun(this, &Controller::OnBackgroundUpdate));
   fade_animator_.updated.connect(sigc::mem_fun(this, &Controller::SetOpacity));
+  fade_animator_.finished.connect([this] {
+    if (animation::GetDirection(fade_animator_) == animation::Direction::BACKWARD)
+      view_window_->ShowWindow(false);
+  });
   modeller_->model_changed.connect(sigc::mem_fun(this, &Controller::OnModelUpdated));
 }
 
@@ -120,6 +124,7 @@
   if (visible_)
   {
     view_->live_background = true;
+    view_window_->ShowWindow(true);
     animation::StartOrReverse(fade_animator_, animation::Direction::FORWARD);
   }
 
@@ -171,7 +176,7 @@
 
   main_layout_->AddView(view_.GetPointer());
 
-  view_window_->ShowWindow(true);
+  view_window_->ShowWindow(false);
   SetOpacity(0.0);
 }